New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] website_cookie_notice #41
Conversation
Please some maintainer set this WIP. |
I set it as needs fixing because WIP doesn't exist yet and I can't create it |
@pedrobaeza @max3903 thanks. This module is now ready to be reviewed |
Thank you very much! 👍 |
<?xml version="1.0" encoding="utf-8"?> | ||
<openerp> | ||
<data> | ||
<template id="cookiebanner" name="cookiebanner" inherit_id="website.theme"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better if you inherit from website.assets_frontend
, because then Odoo joins and reduces all JS and load at the end of body tag (if not ?debug= in URL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better if you inherit from website.assets_frontend, because then Odoo
joins and reduces al JS and load at the end of body tag (if not ?debug= in
URL)Changed, thanks
Spanish translation
…nd reduces all JS and load at the end of body tag
help="just using a simple analytics package? change this to true") | ||
cookieMessage = fields.Char( | ||
string="cookieMessage", | ||
default='We use cookies on this website, you can ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eLBati Could you declare this default value in a way to allow translation?
@antespi I made the suggested changes |
Complete spanish translation
Thanks @antespi ! |
👍 |
👍 |
[ADD] website_cookie_notice
ShopByBrand Feature in Odoo!
[FIX] report layout + translations
https://github.com/eLBati/website/blob/cookie_law/website_cookie_notice/README.rst