Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] website_cookie_notice #41

Merged
merged 12 commits into from Jun 24, 2015
Merged

[ADD] website_cookie_notice #41

merged 12 commits into from Jun 24, 2015

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jun 8, 2015

@eLBati
Copy link
Member Author

eLBati commented Jun 8, 2015

Please some maintainer set this WIP.
Just created to notify the world, but still have to work on it

@pedrobaeza
Copy link
Member

I set it as needs fixing because WIP doesn't exist yet and I can't create it

@eLBati
Copy link
Member Author

eLBati commented Jun 9, 2015

@pedrobaeza @max3903 thanks. This module is now ready to be reviewed

@pedrobaeza
Copy link
Member

Thank you very much!

👍

<?xml version="1.0" encoding="utf-8"?>
<openerp>
<data>
<template id="cookiebanner" name="cookiebanner" inherit_id="website.theme">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better if you inherit from website.assets_frontend, because then Odoo joins and reduces all JS and load at the end of body tag (if not ?debug= in URL)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better if you inherit from website.assets_frontend, because then Odoo
joins and reduces al JS and load at the end of body tag (if not ?debug= in
URL)

Changed, thanks

@eLBati eLBati changed the title [ADD] website_cookie_notice draft module [ADD] website_cookie_notice Jun 23, 2015
@antespi
Copy link
Contributor

antespi commented Jun 23, 2015

@eLBati Spanish translation on this PR eLBati#1
Thanks for your review and merge

help="just using a simple analytics package? change this to true")
cookieMessage = fields.Char(
string="cookieMessage",
default='We use cookies on this website, you can '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eLBati Could you declare this default value in a way to allow translation?

@eLBati
Copy link
Member Author

eLBati commented Jun 23, 2015

@antespi I made the suggested changes

@antespi
Copy link
Contributor

antespi commented Jun 23, 2015

Thanks @eLBati, here eLBati#2 you have the PR to complete Spanish translation

@eLBati
Copy link
Member Author

eLBati commented Jun 23, 2015

Thanks @antespi !

@antespi
Copy link
Contributor

antespi commented Jun 23, 2015

👍

@rafaelbn
Copy link
Member

👍

pedrobaeza added a commit that referenced this pull request Jun 24, 2015
[ADD] website_cookie_notice
@pedrobaeza pedrobaeza merged commit 9e91a03 into OCA:8.0 Jun 24, 2015
bealdav pushed a commit to akretion/website that referenced this pull request Feb 10, 2017
mdietrichc2c added a commit to camptocamp/website that referenced this pull request Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants