[11.0][MIG] website_canonical_url #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
force-pushed
the
11-mig-website_canonical_url
branch
from
95e7286
to
e65fa8e
Compare
simahawk
force-pushed
the
11-mig-website_canonical_url
branch
from
e65fa8e
to
7bc6139
Compare
|
👍 works fine for me |
|
I'm on holidays until next week w/ no chance to play w/ it. I'll get back
and finish the work ;)
…On Thu, Jun 21, 2018 at 12:30 PM Pedro M. Baeza ***@***.***> wrote:
@simahawk <https://github.com/simahawk> #449
<#449> is now merged. Can you please
adjust this PR according that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#460 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVMDcxvaYC8MXd_B_ALTlJjtCQpwvCVks5t-3XFgaJpZM4T7RIg>
.
|
|
Enjoy your holidays! No worry, when you can. |
add a proper description correct import according to review
bug fixes + add languages clean the code fix README file
[FIX] `website_canonical_url` README.rst [IMP] add pagination support
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
simahawk
force-pushed
the
11-mig-website_canonical_url
branch
from
7bc6139
to
70eca56
Compare
|
rebased on v10 and v11 |
pedrobaeza
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on and includes migration for v10 #449TODO: rebase as #449 is merged.