[12.0][MIG] website_lazy_load_image #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] Lint [IMP] img tranformation in ir.ui.view [FIX] jsdocs and flake8 [ADD] Excluding images and more documentation [IMP] Better usage text [FIX] Flake and jslint [ADD] Tests [FIX] missing EOF new line [IMP] Use Savepointcase for tests [IMP] Use Savepointcase for tests
html.fromstring function. Before this commit, the render_template has an issue with views retrieved from a controller, like the wizard of event detail registration, the content was wrapped into an html DOM, this leads a wrong modal behavior. FIX OCA#551
This was referenced Jul 30, 2019
oscarolar
suggested changes
Aug 1, 2019
|
@simahawk |
|
@yajo could you review please |
|
This PR has the |
|
@yajo is on holidays, so go ahead if you think so. |
|
/ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Aug 6, 2019
|
Congratulations, your PR was merged at a827d1f. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.