Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] website_analytics_piwik #678

Merged
merged 13 commits into from Jun 7, 2020

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Jan 8, 2020

No description provided.

@tarteo tarteo force-pushed the 13.0-mig-website_analytics_piwik branch from a71f5fe to 3172335 Compare January 8, 2020 15:03
@astirpe
Copy link
Member

astirpe commented Feb 27, 2020

What about renaming the module to website_analytics_matomo?
See #417

@tarteo
Copy link
Member Author

tarteo commented Mar 6, 2020

@OCA/website-maintainers Piwik was renamed to Matomo for a couple of years now. Should I change the technical name of the module?

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree renaming would be nice, but seeing how old this PR is I won't bother you with it. Please just put a note on the roadmap or somewhere that we should actually do it for v14 when you follow up on the other remarks

@tarteo tarteo force-pushed the 13.0-mig-website_analytics_piwik branch from 3172335 to 4cadf16 Compare June 4, 2020 10:14
[FIX] Black

[ADD] Rename to Matomo note [FIX] Use bootstrap 4 class [REM] 11.0 migration script

[FIX] Prettify xml
@tarteo tarteo force-pushed the 13.0-mig-website_analytics_piwik branch from 4cadf16 to a8436fb Compare June 4, 2020 10:29
@tarteo
Copy link
Member Author

tarteo commented Jun 4, 2020

Can this be merged, please.

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-678-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2ad3eb5 into OCA:13.0 Jun 7, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at da397a8. Thanks a lot for contributing to OCA. ❤️

matteoopenf pushed a commit to matteoopenf/website that referenced this pull request Feb 17, 2023
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants