[13.0] Shopfloor: zone picking refactor shared vars handling #117
Conversation
simahawk
changed the title
simahawk
force-pushed
the
shopfloor-zone-picking-refactor-order
branch
2 times, most recently
from
c68fdc2
to
8e79bfb
Compare
simahawk
force-pushed
the
shopfloor-zone-picking-refactor-order
branch
from
8e79bfb
to
ee031e2
Compare
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
This PR has the |
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-117-by-simahawk-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Stop passing around core variables for this scenario. Zone location, picking type and lines order are now passed via headers. This way they are common to the whole scenario session and they can't get out of sync anymore.
You can now pass custom headers for requests at init or update them on an existing client instance before making the request.
'zone_location' and 'picking_type' are now sent via headers. This way they are shared for each call.
simahawk
force-pushed
the
shopfloor-zone-picking-refactor-order
branch
from
ee031e2
to
649cbff
Compare
|
version bumped manually to merge manually. |
Partial refactor of zone_picking scenario to handle all common vars (zone location, picking type, order) via headers.
This makes easier to preserve the values across all methods of the scenario and make all of them consistent.
ref: 1933