Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] Add barcode on Package Storage Type, use it at reception screen #135

Merged
merged 2 commits into from Jan 21, 2021
Merged

[13.0] Add barcode on Package Storage Type, use it at reception screen #135

merged 2 commits into from Jan 21, 2021

Conversation

carlosserratoro
Copy link

While in the step 'Product Packaging' of the reception screen
of an incoming transfer, allow to scan a barcode for a package
storage type. If a package storage type is found, then fill it
automatically and set the product packaging also from it.

In the reception screen, the order in which the product packaging
and the package storage type has been reversed, because it is the
latter which is now used while scanning, so it comes first now
in the user interface.

Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, waiting for Travis

@simahawk
Copy link
Contributor

@carlosserratoro travis fails because of shopfloor. It has been patched and should be green w/ a rebase.

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you split the commits by module?
Something like:

stock_storage_type: add barcode
stock_reception_screen: select packaging via storage type

stock_reception_screen/__manifest__.py Outdated Show resolved Hide resolved
stock_storage_type/__manifest__.py Outdated Show resolved Hide resolved
@simahawk simahawk changed the title Add barcode on Package Storage Type. Allow to use it at reception screen [13.0] Add barcode on Package Storage Type, use it at reception screen Jan 20, 2021
Carlos Serra-Toro added 2 commits January 20, 2021 15:57
While in the step 'Product Packaging' of the reception screen
of an incoming transfer, allow to scan a barcode for a package
storage type. If a package storage type is found, then fill it
automatically and set the product packaging also from it.

In the reception screen, the order in which the product packaging
and the package storage type has been reversed, because it is the
latter which is now used while scanning, so it comes first now
in the user interface.
@carlosserratoro
Copy link
Author

@simahawk thanks for your review. I attended all your changes. The PR is in green now.

@simahawk
Copy link
Contributor

@carlosserratoro I won't block for commit messages, but as I reported in my comment above it's always better - when possible - to include the module name in the commit message. This is a good rule of thumb and it's even reported in Odoo's guidelines https://www.odoo.com/documentation/13.0/reference/guidelines.html#commit-message-full-description
Just keep it in mind for the next time 😉

@simahawk
Copy link
Contributor

Thanks for your 1st contrib here! 🎉

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-135-by-simahawk-bump-minor, awaiting test results.

@carlosserratoro
Copy link
Author

@carlosserratoro I won't block for commit messages, but as I reported in my comment above it's always better - when possible - to include the module name in the commit message. This is a good rule of thumb and it's even reported in Odoo's guidelines https://www.odoo.com/documentation/13.0/reference/guidelines.html#commit-message-full-description
Just keep it in mind for the next time

OK, I'll do ─ I had understood that you preferred one commit per module, not that the name of the module had to be in the commit message, my fault (thanks for the link!)

@OCA-git-bot OCA-git-bot merged commit 3cd5a69 into OCA:13.0 Jan 21, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1588d0d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants