Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture algorithm change incorrect digest #67

Merged
merged 2 commits into from
May 2, 2021

Conversation

pwinckles
Copy link
Contributor

Fixture for an object's content digest algorithm changing and one of the digests does not match the content file

Copy link
Collaborator

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this fixture the sha512 digests in the v1 manifest for all three files are incorrect. Because the error is in the manifest and not the fixity block, I think the error code should be E092 and not E093

@pwinckles
Copy link
Contributor Author

You are right, there is a bug in my logic that decides if a digest mismatch is E092 or E093

@pwinckles
Copy link
Contributor Author

I changed the error code to E092

@zimeon zimeon requested a review from awoods April 26, 2021 20:09
@awoods awoods merged commit b16bec0 into OCFL:main May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants