Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture old manifest digest incorrect #71

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

pwinckles
Copy link
Contributor

Fixture for an incorrect manifest digest in a non-root inventory

@zimeon
Copy link
Collaborator

zimeon commented Apr 19, 2021

My code reports only E092:

ocfl-validate.py 1.0/bad-objects/E066_E092_old_manifest_digest_incorrect/
[E092a] OCFL Object v1 inventory manifest has digest 17e41ccb166d21a5327d5a2ae1bb48192b8470e1357266c9d119c294cb1e95978569472c9de64fb6d93cbd4dd0aed0bf1e7c47fd1920de17b038a08a85eb4fa1 for file v1/content/file-1.txt which doesn't match calculated digest 07e41ccb166d21a5327d5a2ae1bb48192b8470e1357266c9d119c294cb1e95978569472c9de64fb6d93cbd4dd0aed0bf1e7c47fd1920de17b038a08a85eb4fa1 for that file (see https://ocfl.io/1.0/spec/#E092)
INFO:ocfl.object:OCFL object at 1.0/bad-objects/E066_E092_old_manifest_digest_incorrect/ is INVALID

Copy link
Collaborator

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem reasonable that E066 should be reported as well as E092 because, quite separate from any test of the files in the filesystem, the state of v1 is inconsistent between the v1 and v2 inventories

@awoods awoods merged commit f11f501 into OCFL:main Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants