Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixture for invalid content dir #82

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Add fixture for invalid content dir #82

merged 1 commit into from
Apr 25, 2021

Conversation

pwinckles
Copy link
Contributor

Fixture for invalid content directory

@zimeon
Copy link
Collaborator

zimeon commented Apr 20, 2021 

(py38) simeon@RottenApple fixtures> ../ocfl-validate.py 1.0/bad-objects/E017_invalid_content_dir
[E018] Content directory must not contain a forward slash (/) or be . or .. (see https://ocfl.io/1.0/spec/#E018)
INFO:ocfl.object:OCFL object at 1.0/bad-objects/E017_invalid_content_dir is INVALID

@zimeon
Copy link
Collaborator

zimeon commented Apr 20, 2021

I agree that the error here should be E017 because it is the forward slash in

  "contentDirectory": "content/dir",

that is the problem.

@zimeon zimeon mentioned this pull request Apr 20, 2021
Closed
@zimeon zimeon requested a review from awoods April 20, 2021 14:27
@awoods awoods merged commit b93c6bf into OCFL:main Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awoods awoods awoods approved these changes

@zimeon zimeon zimeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pwinckles @zimeon @awoods