Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version example missing manifest listing? #302

Closed
bseeger opened this issue Feb 13, 2019 · 5 comments
Closed

version example missing manifest listing? #302

bseeger opened this issue Feb 13, 2019 · 5 comments
Labels
OCFL Object Question Further information is requested

Comments

@bseeger
Copy link

bseeger commented Feb 13, 2019

In the version example of an OCFL object, it seems like 'example2.txt' might be missing from the manifest listing. It should be there, correct?

https://ocfl.io/draft/spec/#example-versioned-object

Thanks!

@ahankinson
Copy link
Contributor

Nope. "empty2.txt" is a copied version of "empty.txt", and in v3, "empty.txt" is 'deleted' from the state. So the logical file 'empty2.txt' has the same content state as the physical file 'empty.txt', as signified by them having the same hash.

Essentially, the manifest hashes indicate where a client can resolve the content from, independently of the filename assigned to it in any given version.

@ahankinson ahankinson added the Question Further information is requested label Feb 13, 2019
@ahankinson
Copy link
Contributor

Also, since there is no physical change to the state, the version directories do not need to hold physical files. So while there is a version 3 in state, there is actually no new content. That's why 'empty2.txt' never appears in any version folder.

@zimeon
Copy link
Contributor

zimeon commented Feb 14, 2019

I agree with @ahankinson that the example is correct. This example was generated from the example v1/2/3 state in https://github.com/OCFL/fixtures/tree/master/1.0/content/spec-ex-full using the procedure described in https://github.com/zimeon/ocfl-py/blob/master/README_build_spec_example.md . However, the ocfl-py code was out-of-date: modifications had been made to the example in the spec by-hand. I have updated ocfl-py to bring it up-to-date with the use of type in the current spec (see #232) and the move of fixtures into a 1.0 dir, and have verified that it again generates exactly the spec example.

@awoods
Copy link
Member

awoods commented Feb 15, 2019

I concur with @ahankinson and @zimeon 's responses.

@bseeger , are you still pondering some aspect of this? If so, let's discuss. Otherwise, please feel free to close the issue.

@bseeger
Copy link
Author

bseeger commented Feb 15, 2019

No - this makes much more sense to me now. Thanks for the clarification on the example.

@bseeger bseeger closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCFL Object Question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants