Private datasets don't have a private dataset icon

[luiscape]

In the "my datasets" page, private datasets do have a private dataset icon. However, after you click on that dataset there isn't an icon. I can see the dataset is private by looking at "Visibility: private", but was wondering if it would be nicer to have an icon right next to the title ...

[cjhendrix]

Default CKAN had that, but we didn't carry it across to the new design. Same for deleted. +1 on the idea.

Probably very easy to add it back (est. < 2 hrs).

@ochadataproject ?

[ochadataproject]

can you send me a screen grab? I dont have any private datasets to test this

On Mon, Oct 27, 2014 at 5:44 AM, cjhendrix notifications@github.com wrote:

Default CKAN had that, but we didn't carry it across to the new design.
Same for deleted. +1 on the idea.

Probably very easy to add it back (est. < 2 hrs).

@ochadataproject https://github.com/ochadataproject ?

—
Reply to this email directly or view it on GitHub
#1593 (comment).

[cjhendrix]

Sorry @ochadataproject , this one fell through the cracks.

Here is the view on the dashboard (default CKAN labeling of "private" and "deleted")

The proposed solution is to add a similar functionality to the dataset view page:

[cjhendrix]

Pinging @ochadataproject @yumiendo if this is an ok solution once the issue is prioritized for action.

[ochadataproject]

thanks CJ, looks fine. How does it work with the dataset page that shows
'deleted' since we dont archive the data? also no need to copy Yumi on
pre-existing issues. If I need her help I will bring her in.

thanks

On Thu, Feb 26, 2015 at 5:02 AM, cjhendrix notifications@github.com wrote:

Pinging @ochadataproject https://github.com/ochadataproject @yumiendo
https://github.com/yumiendo if this is an ok solution once the issue is
prioritized for action.

—
Reply to this email directly or view it on GitHub
#1593 (comment).

[cjhendrix]

We don't archive old versions of a resource (if you upload a new version of spreadsheet to the same resource, the old version is gone). However, it's actually not possible to really delete things on ckan, they are just marked as deleted in the database. So a deleted dataset is still in the database, with the last version of its resources and visible only to org members on the org page.

[yumiendo]

added the lock icon(svg) to the google drive
https://drive.google.com/open?id=0B24NBcgmV490VjFQMFRoZ3V3VXc
and sorry for stupid question but what does 'deleted' mean?? if you delete something...why can we still see it?

[luiscape]

@yumiendo jumping on here, in CKAN nothing is ever really deleted. If an user deletes something, only that user will be able to "see" that dataset. That user and system administrators, like us. The advantage of that is that if an user makes a mistake we can "undelete" pretty much anything using the API.

[teodorescuserban]

Remember "Recycle Bin"?

Mie, 9 sept. 2015, 05:35, Luis Capelo notifications@github.com a scris:

@yumiendo https://github.com/yumiendo jumping on here, in CKAN nothing
is ever really deleted. If an user deletes something, only that user will
be able to "see" that dataset. That user and system administrators, like
us. The advantage of that is that if an user makes a mistake we can
"undelete" pretty much anything using the API.

—
Reply to this email directly or view it on GitHub
#1593 (comment).

[danmihaila]

@teodorescuserban it is like Recycle Bin, but there is not "empty recycle bin" button :)

[teodorescuserban]

yes it is. I got a big red one :)
willing to share the knowledge about it :)

În Mie, 9 sept. 2015 la 15:48, danmihaila notifications@github.com a
scris:

@teodorescuserban https://github.com/teodorescuserban it is like
Recycle Bin, but there is not "empty recycle bin" button :)

—
Reply to this email directly or view it on GitHub
#1593 (comment).

[yumiendo]

thanks guys for the info.
I just tested deleting my dummy data...I do see a 'deleted' label on dataset page.

2 questions:

1. am I supposed to be able to click on the label to revive data? (right now it doesnt....)
2. if 'deleted' is not actionable - where do i go to revive data? (I couldnt find it)

I didn't see 'deleted' on dashboard after deleting the file - is it supposed to appear there too? (my dataset - 3rd screenshot)

[luiscape]

@yumiendo I believe there isn't an option in the UI that allows an user to "revive" data. It is only available through the API to the final user at the moment ...

[cjhendrix]

That's correct. I like it when one ancient issue links to another ancient issue. :) #782 Happy we are digging down into these!

[yumiendo]

ahaahaha I was just thinking about 'undelete' action.
is this something people requested or would be useful to the data team?

[luiscape]

@yumiendo at times we have to undelete datasets or resources. It comes around for the Data Team at least once every two months or so. Cc'ing @takavarasha so he can contribute.

[cjhendrix]

From an interface perspective, I just made the issue about undelete because it seems weird to show users deleted datasets but not to give them the ability to undelete. As far as I know, no users have asked for it.

[yumiendo]

@cjhendrix I agree...maybe its an option to make it visible to sys admin only?

[cjhendrix]

I suggest that if we are going to build a button for it, we can easily make it visible to both sysadmins and users who have rights on the dataset to be undeleted.

[teodorescuserban]

There needs to be a research seeing what implications this delete /
undelete have around dataset names and history.

Just to be clear about the "Recycle Bin". From server console, I can either
"purge" a dataset or "undelete" it. Purge will remove it permanently, while
undelete will make it active again.

@luiscape if there are only a handful of datasets per month that need to be
purged / undeleted by the data team, I can take it on. @cjhendrix should be
able to know more if undelete on UI is worth considering.

În Mie, 9 sept. 2015 la 18:09, cjhendrix notifications@github.com a scris:

I suggest that if we are going to build a button for it, we can easily
make it visible to both sysadmins and users who have rights on the dataset
to be undeleted.

—
Reply to this email directly or view it on GitHub
#1593 (comment).

[luiscape]

@yumiendo, @scraperdragon, @cjhendrix to make it clear, there is no feature request from the Data Team. This isn't much of a need nor a problem.

[teodorescuserban]

:)

În Mie, 9 sept. 2015 la 19:36, Luis Capelo notifications@github.com a
scris:

@yumiendo https://github.com/yumiendo, @scraperdragon
https://github.com/scraperdragon, @cjhendrix
https://github.com/cjhendrix to make it clear, there is no feature
request from the Data Team. This isn't much of a need nor a problem.

—
Reply to this email directly or view it on GitHub
#1593 (comment).

[yumiendo]

Sorry to side track from the main topic which is about private icon.

I find 'deleted' label strange without having a way to "undelete" a dataset and the fact that something I deleted doesn't go away kind of scares me. (original issue by CJ #782)
but it sounds like ''undelete" functionality is NOT needed at the moment.

(I just tried this and it's strange. I deleted dataset > the dataset says "deleted" > edited meta data > uploaded new dataset > the dataset still says "deleted")

so to make it easy - shall we REALLY delete(or do not display) dataset if its deleted @cjhendrix @luiscape @takavarasha ?

[luiscape]

Hiding a dataset from a user if it is deleted seems reasonable to me. That is, that user would only be able to see that dataset if she knew the specific URL (or dataset id) of that dataset.

[takavarasha]

I am of the opinion that in the absence of a recycle bin, a deletion must be permanent. There are many reasons why a user might want to delete something. Typical cases are they were doing tests and no longer need the dataset. There are more serious cases though, like when user uploads something sensitive or deeply personal (by mistake) and they just want to take it down. I can imagine the frustration that someone in that situation would feel when they realize that their mistake will not be going away.

Another issue to consider is that a deleted dataset keeps its url. The url is by default constructed from the title of the dataset. Sometimes users will simply want to delete an old dataset and replace it with a new one, which is a reasonable thing to do. However, there will be problems if they give the new dataset the same Title as the one they (or someone else) deleted. I can imagine trying to create a dataset and being told that it already exists, yet I was so sure I had deleted it. Then I search for it and I can't find it. Then go back to try and add it again and being told it already exists... This is rare but has happened several times already.

Finally, soft deletes like the one we currently have work well if there is a recycle bin. Most users are already familiar with how recycle bins work. I would suggest we maintain the soft delete, but add "restore" and "permanently delete" buttons to deleted datasets for users with privileges to edit the dataset in question.

Sent from my iPhone

On Sep 9, 2015, at 3:49 PM, Luis Capelo notifications@github.com wrote:

Hiding a dataset from a user if it is deleted seems reasonable to me. That is, that user would only be able to see that dataset if she knew the specific URL (or dataset id) of that dataset.

—
Reply to this email directly or view it on GitHub.

[danmihaila]

I think we should have a discussion about how to handle the deletion of different entities: dataset, location, organization, user in HDX CKAN. To compare it how it is in CKAN and what are our preferences and of course if we want to change what will be the implications...
@amcguire62 we should set a call with data team and try to figure out what we want and what is best scenario in our case.

[cjhendrix]

Since @amcguire62 is on vacation at the moment, let me try an channel him. :) We got into this discussion because we are trying to action #2227. And the topic of this issue (#1593) is closely related and could be solved at the same time. These are purely about display of a dataset's status and not about the delete/recycle/undelete issue, so I suggest we split them.

This issue plus #2227: display the icons and deleted/private badges on the dataset view page. We can action that now, @yumiendo could you give us a design that takes into account both the icons and the private/deleted labels?

The much older (indeed default ckan) issue #782: we can discuss as Dan suggested (and I agree with @takavarasha proposed solution) but only if we think this is a real pain point for users (and @takavarasha describes a good case in which it would be). Let's move the discussion on that to #782. Because it gets quite deep into the ckan db schema, it might be costly to solve, and I don't want it to hold up what could be a quick fix to #782 and #1593.

[cjhendrix]

By the way, just FYI, I saw today that we do show a deleted badge on the dataset view page. Screen grab from staging is below.

[alexandru-m-g]

@cjhendrix, I think it comes from here: #356

[cjhendrix]

Wow, we're going to start finding dinosaur fossils if we dig much further back . . .

[yumiendo]

Two options to add private icon.
@danmihaila - is it a lot of effort to make "my dataset" view like data list (option b)?

option A. (quick fix)
Add private(lock) icon https://drive.google.com/open?id=0B24NBcgmV490VjFQMFRoZ3V3VXc
next to the title of dataset on
1.my dataset (dashboard, image below)

2.(private) dataset page

option B. (legit? fix)
currently the dashboard section is based on the old design (I believe the design was adopted based on other pages but not designed)

1. my dataset (looks more like "data" list)
   
2. (private) dataset page
   

For both options - private icon is separated from other icon group since its more important key to the owner.

[cjhendrix]

Looks good to me. Option B if easy, option A if not, IMHO.

A couple of additional suggestions to make Yumi's fix cover all cases:

1. additionally put the private icon on the various flavors of search results on org, custom org, location, and custom location
2. @yumiendo, there will also be a deleted badge in some of these locations (see first screen cap on this issue). Maybe we want a small icon for that and place it in the same place as the private icon?
3. There was a third, but it escaped my brain.

Once we get the details nailed down, I think we need to package it all up and present to @amcguire62 .

[yumiendo]

@ochadataproject comp is as above. option B(legit fix) is preferred direction to streamline the design of all pages which is part of another issue... #3555

[ochadataproject]

thanks Yumi the private icon seems fine. I dont see the big difference
between A and B. We we do need to re-do the dashboard at some stage. Also I
know there was a long discussion about delete and undelete. How did we
resolve that?

On Thu, Sep 17, 2015 at 11:05 AM, yumiendo notifications@github.com wrote:

@ochadataproject https://github.com/ochadataproject comp is as above.
option A is preferred direction to streamline the design of all pages which
is part of another issue... #3555
#3555

—
Reply to this email directly or view it on GitHub
#1593 (comment).

[cjhendrix]

Delete/Undelete is part of the #3555 issue that we prioritized yesterday (and the 4 or 5 other issues closely related to it). By the time you read this we will have had the first call on breaking the work down. I think the delete/undelete part will be the last piece to build, but we will have to decide what behavior we want this week so Yumi can design for it.

The ideal solution is to have a recycle bin from which users could permanently delete or restore a dataset, but that's complex to build and users haven't been asking for this.

So the current plan A is to see if we can make deletion permanent. @takavarasha has summed up the reasons why this is important here #1593 (comment)

Plan A may also be complex (to be researched by someone on the dev team next sprint). So plan B
would be to simply make the deleted datasets invisible to users in any dataset list. They would only see it if they navigate to the specific URL and are authorized to see it (it would have a "deleted" badge). This is almost the current behavior now and would be relatively to implement.

Tagging @amcguire62 since he's not on the participant list for this issue yet.

[danmihaila]

@cjhendrix i think we can close this issue. tnx