Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shared link for resource share #4245

Open
cjhendrix opened this issue Jun 16, 2016 · 6 comments
Open

Change shared link for resource share #4245

cjhendrix opened this issue Jun 16, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@cjhendrix
Copy link
Contributor

cjhendrix commented Jun 16, 2016

We currently share the link to the resource which will be either:

  1. a download from hdx in a goo.gl link
  2. a direct link to a remote resource (like a geonode page or dropbox download)

Mixpanel can't count downloads from the 2nd situation.

Change the link shared for resource shares to be the dataset page instead.

Tagging @alexandru-m-g in case I've misunderstood something.

@cjhendrix cjhendrix added this to the Sprint Candidates milestone Jun 16, 2016
@alexandru-m-g
Copy link
Member

What if we share the preview link instead ? I know some resources don't really have a preview but we could imagine a version of the preview page even for those.
Just seemed a bit weird to share the same link whether you share the whole dataset or just a resource.

@cjhendrix
Copy link
Contributor Author

cjhendrix commented Jun 17, 2016

I agree, it is a bit weird, but our preview page doesn't look very nice. I think it can be @yumiendo or @amcguire62 's call. Could we perhaps remove the share links from resources?

@yumiendo
Copy link

I find resource level 'share' lacking bit of information/credentials (user receives a direct link to download and its missing description, meta data, source, etc)

my preference would be to remove the share option from resources and we let users 'share' at dataset level only... unless @amcguire62 thinks this is a deal breaker :)

In addition - shall we add a bit of details in the 'share' email:

Title of dataset (via HDX) <- in the email title

  • include the first 25 words(or so) of description
  • a goo.gl link

example:
Lake Chad Basin FTS Appeal Data (via HDX)
Contains data from OCHA's Financial Tracking Service on the financial requirements and current funding levels for appeals in the Lake Chad Basin crisis countries.
http://goo.gl/5o5LCb

@cjhendrix
Copy link
Contributor Author

Sounds good to me!

@amcguire62
Copy link

+1 good for me also

@alexandru-m-g
Copy link
Member

I have pushed a change for removing the share link for resources.

@yumiendo @danmihaila
About the second change related to the email body, without changing too much the mechanism for how that works we could do something like the following:

  • here is the test dataset with a long formatted description
    description
  • and here is how the email would look like
    description2

Notice that the formatting is gone. To keep it we should probably change the the way this works. Right now the email is actually sent by the user from his email client that automatically opens. To have a nice formatting we would need to send the email from our servers and provide a nice web form for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants