Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prod to dev #6201

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Prod to dev #6201

merged 7 commits into from
Feb 6, 2024

Conversation

danmihaila
Copy link
Contributor

No description provided.

alexandru-m-g and others added 7 commits February 5, 2024 10:23
@alexandru-m-g
HDX-9416 rewriting old token validation logic
db7d883
@alexandru-m-g
HDX-9416 update logic when resetting/forgetting
256d6ab 
+ more refactoring of old onboarding

# Conflicts:
#	ckanext-hdx_users/ckanext/hdx_users/helpers/tokens.py
@danmihaila
Merge pull request #6200 from OCHA-DAP/hotfix/onboarding-refactoring
0502ca3 
PR Hotfix/onboarding refactoring
@danmihaila
Merge pull request #6199 from OCHA-DAP/dev
5063acb 
dev into prod
@ccataalin
HDX-9581 allow trailing slashes for custom/event pages
47d8f20
@ccataalin
update version.py
677e3ea
@danmihaila
Merge pull request #6202 from OCHA-DAP/hotfix/HDX-9581-allow-trailing…
1fd564e 
…-slashes-custom-pages

PR for hotfix for PROD: HDX-9581 allow trailing slashes custom pages
@coveralls
Copy link

Pull Request Test Coverage Report for Build #4882

  • -26 of 52 (50.0%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 70.924%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext-hdx_users/ckanext/hdx_users/views/user.py 1 2 50.0%
ckanext-hdx_users/ckanext/hdx_users/helpers/tokens.py 5 8 62.5%
ckanext-hdx_users/ckanext/hdx_users/logic/register_auth.py 2 7 28.57%
ckanext-hdx_users/ckanext/hdx_users/views/user_register_view.py 2 19 10.53%
Files with Coverage Reduction New Missed Lines %
ckanext-hdx_users/ckanext/hdx_users/helpers/tokens.py 1 47.62%
ckanext-hdx_users/ckanext/hdx_users/logic/register_auth.py 1 69.57%
ckanext-hdx_users/ckanext/hdx_users/views/user_register_view.py 1 33.63%
Totals Coverage Status
Change from base Build #4874: -0.01%
Covered Lines: 11318
Relevant Lines: 15958
💛 - Coveralls

@danmihaila danmihaila merged commit d50fbdf into dev Feb 6, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danmihaila @coveralls @alexandru-m-g @ccataalin