Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR HDX-9626 only try to get username if request arg is a valid string #6247

Merged
merged 2 commits into from
Feb 29, 2024
Merged

PR HDX-9626 only try to get username if request arg is a valid string #6247

merged 2 commits into from
Feb 29, 2024

Conversation

alexandru-m-g
Copy link
Member

  • similarly, only try to get totp_challenger if we have a username

@alexandru-m-g
HDX-9626 only try to get username if request arg is a valid string
335651e 
- similarly, only try to get totp_challenger if we have a username
@coveralls
Copy link

coveralls commented Feb 28, 2024 •
edited

Pull Request Test Coverage Report for Build #5021

Details

  • -6 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 70.767%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext-hdx_users/ckanext/hdx_users/views/user_edit_view.py 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
ckanext-hdx_users/ckanext/hdx_users/views/user_edit_view.py 1 63.86%
Totals Coverage Status
Change from base Build #5016: -0.02%
Covered Lines: 11080
Relevant Lines: 15657
💛 - Coveralls

@danmihaila danmihaila merged commit ecd13b1 into dev Feb 29, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccataalin ccataalin ccataalin approved these changes

@danmihaila danmihaila Awaiting requested review from danmihaila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexandru-m-g @coveralls @ccataalin @danmihaila