Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDX-9070 - Discovery - Google Search Console - Core Web Vitals - Prep… #6365

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

aalecs
Copy link
Member

@aalecs aalecs commented Jun 19, 2024

…are for March 2024

     - remove "empty.css" from webassets
     - remove lazy loading from carousel as now there are few items and is the largest section impacting the "Largest Contentful Paint", so we want the browser to prioritize loading the images
     - removed signup + verify popups from page template as they have been moved to a separate page
     - use <link rel="preconnect" to trigger DNS request for google fonts
     - refactored google recaptcha js to load only in pages where it is needed (large asset)
     - remove individual css file generation for: banner-styles, search-styles, onboarding-styles, onboarding-verify-styles, onboarding-survey-styles,
     - onboarding-styles included in onboarding-bulk-anon or onboarding-bulk-user (2 new css files)

…are for March 2024

         - remove "empty.css" from webassets
         - remove lazy loading from carousel as now there are few items and is the largest section impacting the "Largest Contentful Paint", so we want the browser to prioritize loading the images
         - removed signup + verify popups from page template as they have been moved to a separate page
         - use <link rel="preconnect" to trigger DNS request for google fonts
         - refactored google recaptcha js to load only in pages where it is needed (large asset)
         - remove individual css file generation for: banner-styles, search-styles, onboarding-styles, onboarding-verify-styles, onboarding-survey-styles,
         - onboarding-styles included in onboarding-bulk-anon or onboarding-bulk-user (2 new css files)
…are for March 2024

- add rcssmin to requirements
…are for March 2024

- add rcssmin to requirements
@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build #5457

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 71.871%

Files with Coverage Reduction New Missed Lines %
ckanext-hdx_users/ckanext/hdx_users/views/onboarding.py 3 82.58%
Totals Coverage Status
Change from base Build #5432: 0.2%
Covered Lines: 11771
Relevant Lines: 16378

💛 - Coveralls

@danmihaila danmihaila merged commit e05e4ef into dev Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants