Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDX-9070 - Discovery - Google Search Console - Core Web Vitals - Prep… #6374

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

aalecs
Copy link
Member

@aalecs aalecs commented Jun 27, 2024

…are for March 2024

     - optimize js bundles that are coming from vendor & base
     - move bundles in hdx_theme with similar naming
     - avoid using ckan vendor as no bundling possible
     - move jquery extra to bundle

…are for March 2024

         - optimize js bundles that are coming from vendor & base
         - move bundles in hdx_theme with similar naming
         - avoid using ckan vendor as no bundling possible
         - move jquery extra to bundle
…are for March 2024

         - test reverting to lazy load for imgs
@danmihaila danmihaila merged commit 27d73c2 into dev Jun 27, 2024
3 checks passed
@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build #5465

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 60 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.04%) to 71.871%

Files with Coverage Reduction New Missed Lines %
ckanext-hdx_package/ckanext/hdx_package/helpers/helpers.py 1 68.72%
ckanext-hdx_package/ckanext/hdx_package/helpers/custom_validator.py 4 82.37%
ckanext-hdx_users/ckanext/hdx_users/views/onboarding.py 20 82.58%
ckanext-hdx_package/ckanext/hdx_package/plugin.py 35 71.26%
Totals Coverage Status
Change from base Build #5460: -0.04%
Covered Lines: 11771
Relevant Lines: 16378

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants