Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_hxl output to HAPI resource metadata #28

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Add is_hxl output to HAPI resource metadata #28

merged 7 commits into from
Dec 13, 2023

Conversation

mcarans
Copy link
Collaborator

@mcarans mcarans commented Dec 11, 2023

As part of this change file naming to try to use resource names and formats in preference to inferring from the url

Mike added 5 commits December 8, 2023 12:05
Add is_hxl to HAPI resource metadata
5b89919 
Use resource name and format where available rather than generating filename from URL (breaks names of files used for tests)
Remove "identifier" and rely on file_prefix in kwargs to be consistent
Add is_hxl to HAPI resource metadata
2bfd20a 
Use resource name and format where available rather than generating filename from URL (breaks names of files used for tests)
Remove "identifier" and rely on file_prefix in kwargs to be consistent
Set filename once available
51510c9
Move fixtures to fixtures/input
30495a5
Fix and test for: when use_hxl is True, filename is created in the co…
1fafbbe 
…nstructor if the ConfigurableScraper, but then when data is read later, the filename is not used
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2023 •
edited
Loading

Test Results

41 tests  +4   41 ✔️ +5   3m 4s ⏱️ +13s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌  - 1 

Results for commit c19b96f. ± Comparison against base commit 9312b23.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. 
tests.hdx.scraper.test_runner_get_results.TestRunnerGetResults ‑ test_get_results

tests.hdx.scraper.test_readers.TestReaders ‑ test_hxl_info_file
tests.hdx.scraper.test_runner.TestRunner ‑ test_get_hapi_metadata
tests.hdx.scraper.test_runner.TestRunner ‑ test_get_results
tests.hdx.scraper.test_scrapers_national.TestScrapersNational ‑ test_get_national_use_hxl
tests.hdx.scraper.test_utils.TestUtils ‑ test_get_rowval

♻️ This comment has been updated with latest results.

@mcarans mcarans merged commit dc5d3d5 into main Dec 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mcarans