Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scribo-tests with correct k parameters for sauvola-ms-fg #71

Closed
kba opened this issue Mar 6, 2020 · 1 comment
Closed

Update scribo-tests with correct k parameters for sauvola-ms-fg #71

kba opened this issue Mar 6, 2020 · 1 comment

Comments

@kba
Copy link
Member

kba commented Mar 6, 2020

@bertsky in OCR-D/ocrd_olena#42 (comment)

The CI failure speaks of the need to update our reference data as well: data/scribo-test/data/OCR-D-IMG-BIN-SAUVOLA-MS-FG/OCR-D-SEG-PAGE-SAUVOLA-MS-FG-orig_tiff-BIN_sauvola-ms-fg.png should now be generated with --all-k 0.34 in effect (instead of the previous result which silently used --k2 0.2 --k3 0.3 --k4 0.5).

(I know: this does decrease the quality for this algorithm even further. But this is not a good time to discuss a good way to wrap the different parameterizations. If we want to have control over k for all impl, we must accept that the k2/k3/k4 difference will disappear.)

@kba kba changed the title Update scribo-tests with correct k parameters for sauvola- Update scribo-tests with correct k parameters for sauvola-ms-fg Mar 6, 2020
@kba
Copy link
Member Author

kba commented Mar 6, 2020

Fixed in #72

@kba kba closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant