Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update olena to include https://gitlab.lrde.epita.fr/olena/olena/-/merge_requests/4 #42

Merged
merged 3 commits into from
Mar 6, 2020

Conversation

kba
Copy link
Member

@kba kba commented Mar 6, 2020

@bertsky Feel free to extend and/or merge as you see fit.

@bertsky
Copy link
Collaborator

bertsky commented Mar 6, 2020

The CI failure speaks of the need to update our reference data as well: data/scribo-test/data/OCR-D-IMG-BIN-SAUVOLA-MS-FG/OCR-D-SEG-PAGE-SAUVOLA-MS-FG-orig_tiff-BIN_sauvola-ms-fg.png should now be generated with --all-k 0.34 in effect (instead of the previous result which silently used --k2 0.2 --k3 0.3 --k4 0.5).

(I know: this does decrease the quality for this algorithm even further. But this is not a good time to discuss a good way to wrap the different parameterizations. If we want to have control over k for all impl, we must accept that the k2/k3/k4 difference will disappear.)

@bertsky
Copy link
Collaborator

bertsky commented Mar 6, 2020

@kba after you merged OCR-D/assets#72 we can update repo/assets here.

@kba
Copy link
Member Author

kba commented Mar 6, 2020

@kba after you merged OCR-D/assets#72 we can update repo/assets here.

Done.

@bertsky
Copy link
Collaborator

bertsky commented Mar 6, 2020

Thumbs crossed!

@bertsky bertsky merged commit b14a7d8 into master Mar 6, 2020
@kba kba deleted the update-olena branch March 11, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants