Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace validator: suppress notices about download #450

Closed
bertsky opened this issue Feb 28, 2020 · 0 comments
Closed

workspace validator: suppress notices about download #450

bertsky opened this issue Feb 28, 2020 · 0 comments
Assignees
Projects

Comments

@bertsky
Copy link
Collaborator

bertsky commented Feb 28, 2020

When I run workspace validation these days, I get a lot of these in the final report:

<notice>_validate_dimension: Not executed because --download wasn't set and PAGE might reference remote (Alternatve)Images <...></notice>

IMHO these do not belong in the report at all. If anything, they should be output as warning-level messages in the log during validation.

But to me this is not even justified in the first place: ocrd_validators.workspace_validator.WorkspaceValidator._validate_dimension never actually checks whether the PAGE file exists in the filesystem.

And the problem definitely does not extend to AlternativeImage. (So at least that part of the notice is unwarranted.)

@EEngl52 EEngl52 added this to Backlog in coordinate Mar 3, 2020
@kba kba closed this as completed in 35d9d83 Jul 23, 2020
coordinate automation moved this from Backlog to Done Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
coordinate
  
Done
Development

No branches or pull requests

2 participants