workspace_validator: allow skipping pcgtsid check

[bertsky]

This is necessary as some of our processors do not use set_pcGtsId(file.ID), IINM currently:

• all ocrd_segment processors
• ocrd-keraslm-rate (was already correct)
• ocrd-repair-inconsistencies
• ocrd-detectron2-segment
• ocrd-fileformat-transform (hard to enforce in submodule transform, only for PAGE output)
• ocrd-im6convert (does not apply: only image output)
• ocrd-page-transform

[kba]

Makes sense to have this check optional since we cannot always enforce it (though we should, as you have started, ensure that OCR-D processors handle this correctly).

Minor note: Perhaps just pcgtsid instead of mets_fileid_page_pcgtsid which is easier to type?

[bertsky]

Minor note: Perhaps just pcgtsid instead of mets_fileid_page_pcgtsid which is easier to type?

It's not clear what is meant by just pcgtsid, and it's also not obvious that we are trying to enforce mets:file/@ID=pc:PcGts/@pcGtsId. So I still think the longer identifier is warranted. (We could try to improve the filtering options and docstrings though...)

[bertsky]

@kba in 6991166 I also changed the behaviour of download=True: IMO it was not correct for the workspace validator to convert remote refs to local – instead, that option now does what all our processors do, i.e. downloading on demand. Also, I fixed #450 (which had been closed earlier by accident): not downloaded files must not add to the report, these belong to the logger.

[bertsky]

But actually IMHO the workspace validator should be rewritten even more: It does not make sense to iterate over the same workspace for each PAGE XML test independently. Instead, imagefilename, dimension and page should enter as a page_checks post-parsing step (as I have started with mets_fileid_page_pcgtsid) when the PAGE XML has been downloaded and opened.

[bertsky]

But actually IMHO the workspace validator should be rewritten even more: It does not make sense to iterate over the same workspace for each PAGE XML test independently. Instead, imagefilename, dimension and page should enter as a page_checks post-parsing step (as I have started with mets_fileid_page_pcgtsid) when the PAGE XML has been downloaded and opened.

see #1070 – to be discussed

[kba]

OK, let's merge this now and continue the discussion on improving the validator (which has not been substantially updated in too long a time) in #1070 .

[bertsky]

OK, let's merge this now and continue the discussion on improving the validator (which has not been substantially updated in too long a time) in #1070 .

I thought we do it the other way round, hence #1070 was against this PR branch, not master. Since AFAIK one cannot re-target PRs, I'll close and open a new one against master.

[kba]

Since AFAIK one cannot re-target PR

Oh, I did not realize, sry about that.