METS Server: try to remove UDS socket at sys.exit #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MehmedGIT
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
This PR still does not resolve the issue. Nevertheless, it is a good addition.
After the Processing Server docker container is stopped and removed, the UDS socket stays where it was volume mapped on the host machine. The leftovers (if any) shall be also cleaned in the Makefile for consistency.
Can you prepare a separate PR for that? Or write how to determine the right path and I'll implement it. |
|
I already took care of that in #1164 with the last commit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, just add
atexit(self.shutdown), so the socket file is removed when the process exits. This should cover most of the things that can go wrong, exceptkill -9/C-\which cannot be caught.