Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XSD validators for PAGE and METS, #449 #470

Merged
merged 9 commits into from
Jun 9, 2020
Merged

Conversation

kba
Copy link
Member

@kba kba commented Apr 29, 2020

Adds XSD validators, bundles METS, XLINK and PAGE schemas. XSD validation is part of workspace validation unless page_xsd and/or mets_xsd are skipped.

@kba kba marked this pull request as draft April 29, 2020 15:23
@codecov-io
Copy link

Codecov Report

Merging #470 into master will increase coverage by 0.18%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   80.23%   80.42%   +0.18%     
==========================================
  Files          40       43       +3     
  Lines        2383     2426      +43     
  Branches      432      434       +2     
==========================================
+ Hits         1912     1951      +39     
- Misses        398      402       +4     
  Partials       73       73              
Impacted Files Coverage Δ
...d_validators/ocrd_validators/xsd_mets_validator.py 71.42% <71.42%> (ø)
ocrd_validators/ocrd_validators/xsd_validator.py 90.47% <90.47%> (ø)
ocrd_validators/ocrd_validators/__init__.py 100.00% <100.00%> (ø)
ocrd_validators/ocrd_validators/constants.py 100.00% <100.00%> (ø)
...d_validators/ocrd_validators/xsd_page_validator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cded79...fbbd7be. Read the comment docs.

@EEngl52 EEngl52 added this to In progress in coordinate May 4, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #470 into master will increase coverage by 0.07%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   79.53%   79.60%   +0.07%     
==========================================
  Files          41       44       +3     
  Lines        2516     2559      +43     
  Branches      488      490       +2     
==========================================
+ Hits         2001     2037      +36     
- Misses        424      431       +7     
  Partials       91       91              
Impacted Files Coverage Δ
...d_validators/ocrd_validators/xsd_mets_validator.py 71.42% <71.42%> (ø)
ocrd_validators/ocrd_validators/xsd_validator.py 90.47% <90.47%> (ø)
ocrd_validators/ocrd_validators/__init__.py 100.00% <100.00%> (ø)
ocrd_validators/ocrd_validators/constants.py 100.00% <100.00%> (ø)
...d_validators/ocrd_validators/xsd_page_validator.py 100.00% <100.00%> (ø)
ocrd/ocrd/resolver.py 93.10% <0.00%> (-3.45%) ⬇️
ocrd_models/ocrd_models/ocrd_file.py 90.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7c8a9...5307fc9. Read the comment docs.

@kba kba marked this pull request as ready for review June 7, 2020 20:43
@kba kba changed the title [WIP] add XSD validators for PAGE and METS, #449 Add XSD validators for PAGE and METS, #449 Jun 7, 2020
@kba kba requested review from bertsky and wrznr June 7, 2020 20:44
coordinate automation moved this from In progress to Reviewer approved Jun 8, 2020
Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned a lot about lxml and the class method pattern here!

@kba kba merged commit 855d53f into OCR-D:master Jun 9, 2020
coordinate automation moved this from Reviewer approved to Done Jun 9, 2020
@kba kba deleted the xsd-validators branch June 9, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
coordinate
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants