Write temporary files to local directory by default

[stweil]

Signed-off-by: Stefan Weil sw@weilnetz.de

[stweil]

This fixes a build problem on one of my virtual machines which has only 1.9 GB free in the root filesystem (and so in /tmp, too), but provides a large volume for /HOME with my user data and 25 GB free disk space.

Especially torch (required by ocrd-anybaseocr) seems to need much space in TMPDIR.

[bertsky]

I understand the use-case and the solution is nice. But since often /tmp is in-memory or on faster disks, and automatic clean-up is included, I'd prefer this to be an opt-in, not an opt-out.

IIUC, modern Linux distributions do not set TMPDIR by default (despite it's being a POSIX requirement), but rely on the /tmp fallback. So your patch would change the default behaviour from /tmp to ./tmp.

Have you tried running your build with make ocrd-anybaseocr-crop TMPDIR=$PWD/tmp or export TMPDIR=$PWD/tmp; make ocrd-anybaseocr-crop – without the patch? (If that works, all we'd have to do is add a hint about TMPDIR in the README and for make help.)

[kba]

I concur with @bertsky, let's make this optional and default to /tmp so you CAN do

d=$(mktemp -d -p $PWD) && \
make ocrd-anybaseocr-crop TMPDIR="$d" && \
rm -rf -- "$d"

but do not HAVE to set TMPDIR explicitly

[stweil]

I used TMPDIR=$PWD/tmp make all successfully without this patch, so this modifications just makes life a little bit easier for me.

[bertsky]

I used TMPDIR=$PWD/tmp make all successfully without this patch, so this modifications just makes life a little bit easier for me.

Then I'd say just put export TMPDIR=path/to/ocrd_all/tmp in your ~/.bashrc or in venv/bin/activate and you're good. (We should still add this remark to make help and README, though.)

[kba]

I added a paragraph to the README on this.

[kba]

Can you cherry pick UB-Mannheim@9848636 to master though?

[stweil]

Already done. I also fixed a typo, so you will get a local conflict.