Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cor-asv-fst: fix build #41

Merged
merged 1 commit into from
Jan 8, 2020
Merged

cor-asv-fst: fix build #41

merged 1 commit into from
Jan 8, 2020

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Jan 8, 2020

That should suffice to at least install cor-asv-fst properly. (It still does not make it usable though... so let's keep it deactivated here.)

@kba kba self-requested a review January 8, 2020 17:39
kba
kba approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minimally invasive. Maybe we should add circle ci command to build this? That way it would not be in the docker images but still be tested to build.

@bertsky
Copy link
Collaborator Author

bertsky commented Jan 8, 2020

Maybe we should add circle ci command to build this? That way it would not be in the docker images but still be tested to build.

Good idea. Will look into that (also for cor-asv-ann and for ocrd_keraslm, which at least has tests).

@stweil stweil merged commit 65e1f55 into OCR-D:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bertsky @kba @stweil