Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: run docker pushs in parallel but with steady stdout #77

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Apr 8, 2020

Since we don't run deploy on PR branches, do we have a chance to test whether this actually works before merging?

@bertsky bertsky requested a review from kba April 8, 2020 17:29
@kba
Copy link
Member

kba commented Apr 8, 2020

do we have a chance to test whether this actually works before merging?

Not without changing the configuration file. Let's wait until https://app.circleci.com/pipelines/github/OCR-D/ocrd_all/111/workflows/3a12fd02-de90-477c-a8ad-17e3c63eb40c/jobs/117 finishes and merge then. If it doesn't work we can fix it later.

Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kba kba merged commit a1c7217 into OCR-D:master Apr 9, 2020
@bertsky bertsky deleted the fix-ci-network-timeouts branch August 21, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants