Does not produce a valid workspace

[mikegerber]

It seems ocrd-olena-binarize does not produce a valid workspace anymore since ocrd workspace validate now checks PcGtdIs against METS IDs:

<report valid="false">
  <warning>pc:PcGts/@pcGtsId differs from mets:file/@ID: "" !== "OCR-D-IMG-BINPAGE_00000024"</warning>
</report>

[mikegerber]

@kba Should the test target include a test for this, i.e. validating? (I believe it should, for every processor, but we should discuss it.)

[kba]

@kba Should the test target include a test for this, i.e. validating?

It probably should, yes.

At the very least, this particular test should be skippable. OCR-D/core#553

[mikegerber]

@kba Another idea: I routinely run validation after running each processor to catch problems early. If there was a standard option --validate in core (supplemented by a config file that configures e.g. --skip options), this pattern:

ocrd-olena-binarize --overwrite -I $INPUT_FILE_GRP -O OCR-D-IMG-BINPAGE,OCR-D-IMG-BIN -P impl sauvola-ms-split
ocrd workspace validate $validate_options
                                                                                                                                                              
ocrd-sbb-textline-detector --overwrite -I OCR-D-IMG-BINPAGE -O OCR-D-SEG-LINE -P model /var/lib/textline_detection
ocrd workspace validate $validate_options

would simplify to:

ocrd-olena-binarize --validate --overwrite -I $INPUT_FILE_GRP -O OCR-D-IMG-BINPAGE,OCR-D-IMG-BIN -P impl sauvola-ms-split
ocrd-sbb-textline-detector --validate --overwrite -I OCR-D-IMG-BINPAGE -O OCR-D-SEG-LINE -P model /var/lib/textline_detection

I might be the one user to use the validation a lot, so I am not sure if it's really a good fit as a "core option".

[kba]

that's a good idea and would not be difficult to implement. can you open an issue in OCR-D/core with that proposal?