segment-region: use BlockPolygon #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertsky
force-pushed
the
use-blockpolygon
branch
2 times, most recently
from
4f2edd4
to
83b4eef
Compare
bertsky
force-pushed
the
use-blockpolygon
branch
from
83b4eef
to
b0ba660
Compare
|
Sorry about the force-pushing noise: having a hard time getting used to RST. |
|
You can also use Markdown for the README if you prefer that, just have to change the setup.py so it's correctly displayed on PyPI. |
wrznr
approved these changes
Jul 18, 2019
| @@ -125,12 +125,12 @@ def process(self): | |||
| bin_bbox = image.getbbox() | |||
| if not bin_bbox: | |||
| # this does happen! | |||
| LOG.debug("Ignoring region '%s' because its binarization is empty", ID) | |||
| LOG.info("Ignoring region '%s' because its binarization is empty", ID) | |||
There was a problem hiding this comment.
So, you decided to take the more-verbose road. We have to see if this is feasible in the long run.
There was a problem hiding this comment.
Sorry, then I misunderstood you. So you want this to stay in DEBUG here, and downgrade similar statements in segment-region to DEBUG as well?
|
Sorry, I should have made the last 3 on a separate branch/PR. Just sneaking by your approval! |
|
Sneaky sneaky 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that sirfz/tesserocr#185 is merged, we can annotate Tesseract's polygon results instead of just the bounding box. Still not making
crop_polygonstrue by default, because I believe these things cannot be trusted.I have linked with
tesserocrrequirement from Github instead of the PyPI pkg, because a new release will likely not arrive before Tesseract 5.