Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid automatically switching to ReadingOrder editing #187

Closed
bertsky opened this issue May 28, 2020 · 6 comments
Closed

avoid automatically switching to ReadingOrder editing #187

bertsky opened this issue May 28, 2020 · 6 comments
Labels
Type: Enhancement Indicates an enhancement proposal for an existing feature

Comments

@bertsky
Copy link

bertsky commented May 28, 2020

For some reason, whenever I finish some action in SEGMENTSRegions on a region imported from PAGE-XML – for example change the class – the UI will immediately switch over to SEGMENTSReading Order afterwards.

This is annoying and elusive: I would understand it if the region did not have a position in ReadingOrder yet (as do newly created regions) in order to "fill the hole right away", but to summon this view when there is actually nothing to do feels strange.

Is there anything I can do for mitigation? Can ReadingOrder editing be disabled complete (maybe in larex.config)?

@maxnth
Copy link
Member

maxnth commented May 29, 2020

Opening the reading order collapsible when changing to another region type (except ImageRegion, which would change the RO by being removed from it) does indeed seem not that useful.

Can ReadingOrder editing be disabled complete

Sadly not at the moment, but maybe it would make sense to add it in to the settings in the UI and make it saveable (related to #182).

@maxnth
Copy link
Member

maxnth commented May 30, 2020

Added in branch fix/readingOrderDisplay.

The reading order and the "reading order menu" will now only be displayed on actions which alter the existing reading order (as in removes element from an existing reading order).

A switch was added to Advanced Settings in the sidebar to completely suppress the forced display of the reading order (menu), even when actions alter the reading order.

Will be added to master in the next minor release (probably 0.3.2) in the near future.

@maxnth maxnth added Type: Enhancement Indicates an enhancement proposal for an existing feature fixed labels May 30, 2020
@bertsky
Copy link
Author

bertsky commented Jun 4, 2020

This works fine in general – thanks!

However, I noticed that ReadingOrder still gets activated after using the undo button. (Plus I am not sure this works at all in edit mode instead of segment...)

@maxnth
Copy link
Member

maxnth commented Jun 5, 2020

I noticed that ReadingOrder still gets activated after using the undo button.

This should be fixed now.

Plus I am not sure this works at all in edit mode instead of segment

Seems to work for me in both modes.
Any concrete examples where it doesn't work?

@bertsky
Copy link
Author

bertsky commented Jun 5, 2020

I noticed that ReadingOrder still gets activated after using the undo button.

This should be fixed now.

It is – thanks a lot!

Plus I am not sure this works at all in edit mode instead of segment

Seems to work for me in both modes.
Any concrete examples where it doesn't work?

No, cannot reproduce anymore. Maybe built the wrong version earlier.

But in edit mode, all collapsible settings and regionSegmentationSettings are hidden, so I gathered the default settings-hint-reading-order=checked would be in effect. I guess there's another place I overlooked which controls this.

@maxnth
Copy link
Member

maxnth commented Jun 25, 2020

The option for disabling/activating reading order hints is now displayed in Edit mode as well.
Fix was merged in dev and will therefore be included in the upcoming release.

@maxnth maxnth closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Indicates an enhancement proposal for an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants