-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add menhir skeleton #92
Conversation
3430741
to
65e1232
Compare
drom.opam
Outdated
@@ -26,7 +26,7 @@ bug-reports: "https://github.com/ocamlpro/drom/issues" | |||
dev-repo: "git+https://github.com/ocamlpro/drom.git" | |||
tags: "org:ocamlpro" | |||
build: [ | |||
["dune" "subst"] {dev} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this comment ocaml/opam-repository#17730 (comment) , Kate asked us to switch from {pinned}
to {dev}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated, I didn't touched it by hand, so I'm not sure why it changed.
(package !{package-name})) | ||
!(package-dune-trailer) | ||
|
||
(ocamllex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines are automatically added by drom
if the line generators = [ "ocamllex", "menhir" ]
is in the package.toml
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a package.toml
file with the corresponding line and it doesn't seem to work.
If you rebase on the last I have used the convention to use dashes instead of underscores in skeleton names until now. Either we switch all of them to underscores, or this skeleton should follow the same convention. |
c56fe0b
to
a886b51
Compare
* Fix skeleton instantiation during `drom new` to remove a bug to to source files not yet created when `dune` files are instantiated * Add the line `(using menhir 2.0)` in `dune-project` to prevent `dune` from modifying this file at runtime * Rename `menhir_lib` to `menhir-lib` * Add [tools] dependency to `menhir`, with version > 2019
…keleton * Change the program and menhir skeletons to underscorify library names. * Fix scripts/test-drom-skeletons.sh to create a project with a different name from the skeleton name
No description provided.