Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add menhir skeleton #92

Merged
merged 5 commits into from
Dec 16, 2020
Merged

add menhir skeleton #92

merged 5 commits into from
Dec 16, 2020

Conversation

zapashcanon
Copy link
Member

No description provided.

share/drom/skeletons/packages/menhir/dune_ Outdated Show resolved Hide resolved
share/drom/skeletons/packages/menhir/dune_ Outdated Show resolved Hide resolved
drom.opam Outdated
@@ -26,7 +26,7 @@ bug-reports: "https://github.com/ocamlpro/drom/issues"
dev-repo: "git+https://github.com/ocamlpro/drom.git"
tags: "org:ocamlpro"
build: [
["dune" "subst"] {dev}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this comment ocaml/opam-repository#17730 (comment) , Kate asked us to switch from {pinned} to {dev}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated, I didn't touched it by hand, so I'm not sure why it changed.

(package !{package-name}))
!(package-dune-trailer)

(ocamllex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are automatically added by drom if the line generators = [ "ocamllex", "menhir" ] is in the package.toml file.

Copy link
Member Author

@zapashcanon zapashcanon Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a package.toml file with the corresponding line and it doesn't seem to work.

@lefessan
Copy link
Member

If you rebase on the last master (10 minutes ago...), you should be able to write menhir_lib/package.toml file for the package skeleton, in particular, it should contain a dependency towards menhirLib, and a line generators = [ "ocamllex", "menhir" ], no ?

I have used the convention to use dashes instead of underscores in skeleton names until now. Either we switch all of them to underscores, or this skeleton should follow the same convention.

Fabrice Le Fessant added 3 commits December 16, 2020 17:28
* Fix skeleton instantiation during `drom new` to remove a bug to to source
  files not yet created when `dune` files are instantiated
* Add the line `(using menhir 2.0)` in `dune-project` to prevent `dune`
  from modifying this file at runtime
* Rename `menhir_lib` to `menhir-lib`
* Add [tools] dependency to `menhir`, with version > 2019
…keleton

* Change the program and menhir skeletons to underscorify library
  names.
* Fix scripts/test-drom-skeletons.sh to create a project with a different
  name from the skeleton name
@zapashcanon zapashcanon marked this pull request as ready for review December 16, 2020 17:38
@zapashcanon zapashcanon merged commit b694f28 into OCamlPro:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants