Skip to content

Commit

Permalink
Changed tests to follow new function parameter alignment request
Browse files Browse the repository at this point in the history
  • Loading branch information
AltGr committed Mar 13, 2013
1 parent e521bae commit 339d3f7
Show file tree
Hide file tree
Showing 8 changed files with 454 additions and 12 deletions.
File renamed without changes.
File renamed without changes.
422 changes: 411 additions & 11 deletions tests/failing.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/failing/js-args.ml
Expand Up @@ -12,7 +12,7 @@ let should_check_can_sell_and_marking regulatory_regime =

(* CR pszilagyi: What would you say about this one: *)
let f = fun x -> ghi
x
x

let x =
try x with a -> b
Expand Down
22 changes: 22 additions & 0 deletions tests/failing/js-functor.ml
@@ -0,0 +1,22 @@
module M =
F (G)
(H) (* OK, line up the functor args *)

module M =
F
(G)
(H)

(* CR pszilagyi: To me, this looks fine as it is. The rule seems fine as "indent
arguments by 2". To illustrate, with a case where the functor name is longer: *)
module M =
Functor (G)
(H)
(I)

(* CR pszilagyi: That is pretty awful. We really want this? Let's at least discourage
the F style for multi-argument functors? *)
include F(struct
let blah _
end)
(G)
File renamed without changes.
20 changes: 20 additions & 0 deletions tests/failing/js-let.ml
@@ -0,0 +1,20 @@
let foo
some very long arguments that we break onto the next line
=
bar ();
baz

(* The picture shows where we want the `=' to be. However, Tuareg currently moves it over
to line up with the arguments.
Perhaps this is merely a personal preference, but that seems ugly to me.
pszilagyi: It's consistent with other infix operators (although this is syntax) for it
to be where you prefer. *)

let foo arguments
= bar

let foo
arguments
= bar
File renamed without changes.

0 comments on commit 339d3f7

Please sign in to comment.