Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changed tests to follow new function parameter alignment request
- Loading branch information
Showing
8 changed files
with
454 additions
and
12 deletions.
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
module M = | ||
F (G) | ||
(H) (* OK, line up the functor args *) | ||
|
||
module M = | ||
F | ||
(G) | ||
(H) | ||
|
||
(* CR pszilagyi: To me, this looks fine as it is. The rule seems fine as "indent | ||
arguments by 2". To illustrate, with a case where the functor name is longer: *) | ||
module M = | ||
Functor (G) | ||
(H) | ||
(I) | ||
|
||
(* CR pszilagyi: That is pretty awful. We really want this? Let's at least discourage | ||
the F style for multi-argument functors? *) | ||
include F(struct | ||
let blah _ | ||
end) | ||
(G) |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
let foo | ||
some very long arguments that we break onto the next line | ||
= | ||
bar (); | ||
baz | ||
|
||
(* The picture shows where we want the `=' to be. However, Tuareg currently moves it over | ||
to line up with the arguments. | ||
Perhaps this is merely a personal preference, but that seems ugly to me. | ||
pszilagyi: It's consistent with other infix operators (although this is syntax) for it | ||
to be where you prefer. *) | ||
|
||
let foo arguments | ||
= bar | ||
|
||
let foo | ||
arguments | ||
= bar |
File renamed without changes.