Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout and styling tweaks #75

Merged
merged 1 commit into from
May 17, 2019
Merged

Layout and styling tweaks #75

merged 1 commit into from
May 17, 2019

Conversation

af
Copy link
Contributor

@af af commented May 17, 2019

First off, thanks for this outstanding collection of OCaml resources! This PR is completely unsolicited, but I've been tinkering with some style changes to the site and thought I would submit them for consideration. I kept all css changes contained to css/style.scss, as it looks like that's where theme overrides should go.

Before:
Screen Shot 2019-05-17 at 10 35 06 AM

After:
Screen Shot 2019-05-17 at 10 35 17 AM

@af
Copy link
Contributor Author

af commented May 17, 2019

This should help a bit with #50 as well (I just noticed that issue). The sidebar content is now shown at full width below the page's content. The only issue I noticed on mobile is at small widths, the github link can overlap the heading a bit.

@bluddy
Copy link
Member

bluddy commented May 17, 2019

Beautiful job! I was hoping someone more knowledgeable at CSS would be able to improve the look of the site. Thanks a bunch!

@bluddy bluddy merged commit 42918b9 into OCamlverse:master May 17, 2019
@af af deleted the design-tweaks branch May 17, 2019 17:53
@af
Copy link
Contributor Author

af commented May 17, 2019

Thanks! Feel free to ping me if you have any css issues for the site, I can try to take a look. I'm not a designer, but like to pretend that I am :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants