fix $apply with $groupby with more than one property & $top #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethOkerio
changed the title
KenitoInc
previously approved these changes
Aug 9, 2023
|
@ElizabethOkerio Curious, did this change between 7.x and 8.x? |
|
@gathogojr Yes.. This came about with the binders restructuring changes. This is what has been causing the $appy and $groupby issues in 8.x.. This is the change I made here #919 that fixed some of the issues in 8.x. In 7.x the flattening of properties is done but in 8.x> 8.05 where the restructuring of binders was done the flattening was left out. |
ElizabethOkerio
force-pushed
the
fix/apply_with_grouping_by_more_than_one_prop
branch
from
122fbff
to
9cb3fdf
Compare
xuzhg
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #979 and #969
Moved the
EnsureFlattenedPropertiesmethod fromApplyBindinBinderExtensionsclass toApplyToCoreinOrderByQueryOptionclass. The reason for this is to avoid theEnsureFlattenedPropertiesbeing called more than once since it was in a foreach loop and was assigning null to FlattenedProperties on the second loop.