Support Minimal API #1140

xuzhg · 2023-12-15T04:18:44Z

Fixes #578

Minimal APIs are a simplified approach for building fast HTTP APIs with ASP.NET Core. You can build fully functioning REST endpoints with minimal code and configuration. Skip traditional scaffolding and avoid unnecessary controllers by fluently declaring API routes and actions. For example, the following code creates an API at the root of the web app that returns the text, "Hello World!".

var app = WebApplication.Create(args);
app.MapGet("/", () => "Hello World!");
app.Run();

Customer want to get the OData query options functionalities. We can provide couple solutions

Provide a HttpRequest-less ODataQueryOptions< T > (Without using IEdmModel, using CLR type directly) and customer can use it in the Delegate to generate the Linq Expression and apply to the data.
Use the existing ODataQueryOptions< T >. It convers two scenarios: 1) EdmModel based 2) Non-EdmModel (but will create EdmModel on the fly)

This PR is to support the second.

app.MapGet("/schools", (AppDb db, ODataQueryOptions<School> options) => {
     ....
    return options.ApplyTo(db.Schools);
});

Then, client can send request the "/schools" using OData query options, for example, $select, etc.

habbes · 2024-01-04T08:53:23Z

Happy to see some progress on minimal API support @xuzhg
Would you consider adding more context or a more detailed breakdown of the PR implementation?

Also can you clarify the extent of OData features we support in this PR and what do not support (and do not plan to support).
I assume OData routing is not supported at all. Does this support model binding? Delta? Or is support restricted to only ODataQueryOptions<T>?

xuzhg · 2024-01-04T20:12:55Z

Happy to see some progress on minimal API support @xuzhg Would you consider adding more context or a more detailed breakdown of the PR implementation?

Also can you clarify the extent of OData features we support in this PR and what do not support (and do not plan to support). I assume OData routing is not supported at all. Does this support model binding? Delta? Or is support restricted to only ODataQueryOptions<T>?

Thanks for your feedback. Actually, the product codes in the PR changed less.

OData routing

In my understanding, most of customers only want to get the 'OData Query functionalities" when building the minimal API. They don't want to know "Entity Type, Complex Type", or "Entity set, Singleton, Navigation Source, Navigation Property", concepts like these. Even thought they don't want to know about "Key Segement" and It should come after "Collection Segement". So, there's no "OData routing" at all. However, we can add "OData routing" mechanise, for example:

app.MapOData<ODataServiceContext>(EdmModel);

Where, ODataServiceContext is a class containing OData routings.

Does this support model binding?

In my understanding, ASP.NET Core doesn't add model binding for minimal API. So we can't add it. In the minimal API, it only contains the parameter binding, it's same as "model binding" and most of logics are same. For example, You can put [FromBody] on the parameter to bind the parameter from request body. There's new solution to customize the parameter binding. That's what I used in my PR to binding the ODataQueryOptiont< T >.

Delta< T > ? DeltaSet< T >

I think we should support to bind those types. I also added the comments in my PR to support them. It could be a little bit same as ODataQueryOption< T > implementation. It's not complicated but I think let's do it step by step. Before implementing it, let's finish our first BrainStorm on the initial design.

To Be Discussion

OData payload is JSON payload. I think it's time to consider to use Default Json serializer/deserializer. The only thing is to implement the JsonConverter on the OData object. We can sync it more later.

julealgon · 2024-01-16T21:48:35Z

OData payload is JSON payload. I think it's time to consider to use Default Json serializer/deserializer. The only thing is to implement the JsonConverter on the OData object. We can sync it more later.

Honestly... this would be the biggest improvement to OData in years and would avoid so many problems.

At the same time... seems ambitious to consider that alongside the Minimal API changes 😅. As much as I want that, I'd avoid doing them together, or potentially even in the same release.

robertmclaws · 2024-01-17T02:08:49Z

It would be ABSOLUTELY AMAZING if OData switched to out-of-the-box System.Text.Json serialization with converters. I think it would improve perf by at least 50%, and I wouldn't be surprised if you saw a 200-400% improvement.

Probably needs a separate work branch tho. Hopefully the unit tests are designed to be able to handle this.

Happy to help wherever possible.

habbes · 2024-01-17T06:47:11Z

I agree we stand to gain a lot from leveraging System.Text.Json. But it's not a trivial change given all the scenarios that OData's current serialization supports as well as adherence to the OData spec. However, this is something we're currently looking into. I'll share results from the progress soon. (see: OData/odata.net#2798)

habbes

Will you add tests?

habbes · 2024-01-19T04:40:00Z

sample/ODataMiniApi/MetadataHandler.cs

+
+namespace ODataMiniApi;
+
+public class MetadataHandler


Given that this is in the sample project, does this mean this is something the customer will have to write, or does this work out of the box?

habbes · 2024-01-19T04:40:39Z

sample/ODataMiniApi/MetadataHandler.cs

+            SkipValidation = false
+        };
+
+        // we can't use response body directly since ODL writes the JSON CSDL using Synchronous operations.


Should we prioritize making this async in ODL?

habbes · 2024-01-19T04:59:45Z

sample/ODataMiniApi/Program.cs

+app.MapGet("/customized/schools", (AppDb db, ODataQueryOptions<School> options) => {
+    db.ChangeTracker.QueryTrackingBehavior = QueryTrackingBehavior.NoTracking;
+    return options.ApplyTo(db.Schools);
+}).UseOData("customized"); // In customized OData, MailAddress and Student are complex types, you can also use 'IODataModelConfiguration'


How would you use IODataModelConfiguration?

habbes · 2024-01-19T05:25:47Z

src/Microsoft.AspNetCore.OData/Edm/IODataModelConfiguration.cs

+        /// </summary>
+        /// <param name="context">The HttpContext.</param>
+        /// <param name="builder">The <see cref="ODataModelBuilder">builder</see> used to apply configurations.</param>
+        void Apply(HttpContext context, ODataModelBuilder builder);


Do we envision that more arguments could be needed in the future, such that we could use an ODataModelConfiguratonOptions class to encapsulate the options, or is an ODataModelBuilder sufficient?

habbes · 2024-01-19T05:42:56Z

src/Microsoft.AspNetCore.OData/Query/Wrapper/SelectExpandWrapperConverter.cs

@@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.OData.Query.Wrapper
    /// <summary>
    /// Supports converting <see cref="SelectExpandWrapper{T}"/> types by using a factory pattern.
    /// </summary>
-    internal class SelectExpandWrapperConverter : JsonConverterFactory
+    public class SelectExpandWrapperConverter : JsonConverterFactory


Why is this made public?

habbes · 2024-01-19T05:50:40Z

src/Microsoft.AspNetCore.OData/Edm/IODataEndpointModelMapper.cs

+    /// A cache for <see cref="Endpoint"/> and <see cref="IEdmModel"/> mapping.
+    /// It's typically used for minimal API scenario.
+    /// </summary>
+    public interface IODataEndpointModelMapper


What is the likelihood that the customer will want to customize this? Maybe we should make it internal until there's explicit/clear demand from the customer to make it extensible, that way it can give us room to change the design without breaking changes.

danielpastoor · 2024-02-09T10:48:41Z

Is there any update on this pull-request?

xuzhg added 2 commits December 14, 2023 20:07

fixes #578: Support minimal API

e302c8c

add more scenarios into readme.md

182f203

xuzhg requested review from ElizabethOkerio, KenitoInc, habbes, mikepizzo and gathogojr December 15, 2023 04:18

Enable OData metadata endpoint.

a673bed

cilerler approved these changes Jan 5, 2024

View reviewed changes

habbes reviewed Jan 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Minimal API #1140

Support Minimal API #1140

xuzhg commented Dec 15, 2023

habbes commented Jan 4, 2024 •

edited

xuzhg commented Jan 4, 2024

julealgon commented Jan 16, 2024

robertmclaws commented Jan 17, 2024

habbes commented Jan 17, 2024

habbes left a comment

habbes Jan 19, 2024

habbes Jan 19, 2024

habbes Jan 19, 2024

habbes Jan 19, 2024

habbes Jan 19, 2024

habbes Jan 19, 2024

danielpastoor commented Feb 9, 2024

Support Minimal API #1140

Are you sure you want to change the base?

Support Minimal API #1140

Conversation

xuzhg commented Dec 15, 2023

habbes commented Jan 4, 2024 • edited

xuzhg commented Jan 4, 2024

OData routing

Does this support model binding?

Delta< T > ? DeltaSet< T >

To Be Discussion

julealgon commented Jan 16, 2024

robertmclaws commented Jan 17, 2024

habbes commented Jan 17, 2024

habbes left a comment

Choose a reason for hiding this comment

habbes Jan 19, 2024

Choose a reason for hiding this comment

habbes Jan 19, 2024

Choose a reason for hiding this comment

habbes Jan 19, 2024

Choose a reason for hiding this comment

habbes Jan 19, 2024

Choose a reason for hiding this comment

habbes Jan 19, 2024

Choose a reason for hiding this comment

habbes Jan 19, 2024

Choose a reason for hiding this comment

danielpastoor commented Feb 9, 2024

habbes commented Jan 4, 2024 •

edited