Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] OperationAttribute + ModelBuilder.Action = identical model entries #652

Closed
robertmclaws opened this issue Oct 5, 2019 · 0 comments
Assignees
Labels

Comments

@robertmclaws
Copy link
Collaborator

The OperationAttribute system does not check to see if the operation in question already exists before adding a new reference. The end result is that there can be multiple references to the same operation in the completed model, without throwing an error.

Assemblies Affected

Restier 1.0.0 RC1

Steps to Reproduce

            //var statement = modelBuilder.Action("GetSalesPlanStatement")
            //    .Returns<SalesPlanStatement>();
            //statement.Parameter<SalesTargets>("targets");
  • Add the GetSalesPlanStatement operation and tag it with [Operation].

Expected Rresult

Only one Operation should be registered with the model.

Actual Result

Two Operations are registered with the model.

@robertmclaws robertmclaws self-assigned this Oct 5, 2019
@robertmclaws robertmclaws added this to the 2.0 milestone Oct 5, 2019
@robertmclaws robertmclaws removed this from the 2.0 milestone Dec 5, 2023
@robertmclaws robertmclaws closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
@robertmclaws robertmclaws changed the title OperationAttribute + ModelBuilder.Action = identical model entries [2.0] OperationAttribute + ModelBuilder.Action = identical model entries Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant