Improve model built exception been thrown #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinadragon0515
force-pushed
the
model2
branch
3 times, most recently
from
3fb294d
to
99f46a8
Compare
| { | ||
| model = api.GetModelAsync().Result; | ||
| } | ||
| catch (Exception e) |
There was a problem hiding this comment.
better use AggreateException and no need to check if it contains an InnerException (because it always has)
There was a problem hiding this comment.
|
Looks good to me. |
chinadragon0515
force-pushed
the
model2
branch
2 times, most recently
from
dbb8062
to
39d8552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #432 .
Description
If we use call api.GetModelAsync().Result, then the exception been thrown is wrapped and only inner exception has meaningful message.
If we change to await api.GetModelAsync(), then the exception been thrown will not be wrapped and the exception is meaningful.