Make model auto pop keys from Entity framework. #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,34 +12,71 @@ | |||
| <Property Name="Picture" Type="Edm.Binary" /> | |||
| <NavigationProperty Name="Products" Type="Collection(Microsoft.OData.Service.Sample.Northwind.Models.Product)" /> | |||
| </EntityType> | |||
| <EntityType Name="Contact"> | |||
| <EntityType Name="Product"> | |||
There was a problem hiding this comment.
Already have detail compare, the changes in this file is only sequence change, no single line content change.
chinadragon0515
force-pushed
the
modelkey
branch
from
e949d41
to
00cbdb0
Compare
chinadragon0515
force-pushed
the
modelkey
branch
from
00cbdb0
to
c542db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #413 .
Description
In Restier 0.5, the model building uses Web APi OData conversion model builder which finds keys of entity type based on ,
a. Whether there is any proeprty marked with key attribute.
b. Whether there is property with name ID or entitytypeNameID
But if the entity type does not define key in this way, then model build will fail
This issue retrieves keys from entity framework and set to model builder.
Checklist (Uncheck if it is not completed)