New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 505 and add patch test cases, also support key as segment and add CORS header #507

Merged
merged 4 commits into from Sep 2, 2016

Conversation

Projects
None yet
3 participants
@mirsking
Contributor

mirsking commented Sep 1, 2016

Issues

This pull request fixes issue #505, also support key as segment and add CORS header.

Description

Complex type property now can be patched rightly.

Checklist (Uncheck if it is not completed)

  • [ x ] Test cases added
  • [ x ] Build and test with one-click build and test script passed

@mirsking mirsking changed the title from fix issue 505 and add patch test cases to fix issue 505 and add patch test cases, also support key as segment and add CORS header Sep 1, 2016

@@ -220,7 +220,7 @@ private void SetValues(DbEntityEntry dbEntry, DataModificationItem item, Type re
propertyPair.Key));
}
value = Activator.CreateInstance(type);
value = propertyEntry.CurrentValue;
SetValues(value, type, dic);

This comment has been minimized.

@chinadragon0515

chinadragon0515 Sep 2, 2016

Contributor

I am OK for this changes.
But add a TODO to line 257, the SetValues method is called by both patch and patch, we need to consider complex property has other complex type property cases.

Open an issue to track this and add to that TODO.

@chinadragon0515 chinadragon0515 merged commit b113b14 into OData:master Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment