Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 505 and add patch test cases, also support key as segment and add CORS header #507

merged 4 commits into from
Sep 2, 2016


Copy link

@mirsking mirsking commented Sep 1, 2016


This pull request fixes issue #505, also support key as segment and add CORS header.


Complex type property now can be patched rightly.

Checklist (Uncheck if it is not completed)

  • [ x ] Test cases added
  • [ x ] Build and test with one-click build and test script passed

@mirsking mirsking changed the title fix issue 505 and add patch test cases fix issue 505 and add patch test cases, also support key as segment and add CORS header Sep 1, 2016
@@ -220,7 +220,7 @@ private void SetValues(DbEntityEntry dbEntry, DataModificationItem item, Type re

value = Activator.CreateInstance(type);
value = propertyEntry.CurrentValue;
SetValues(value, type, dic);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK for this changes.
But add a TODO to line 257, the SetValues method is called by both patch and patch, we need to consider complex property has other complex type property cases.

Open an issue to track this and add to that TODO.

@chinadragon0515 chinadragon0515 merged commit b113b14 into OData:master Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants