Convert DateTimeOffset to DateTime when necessary

[0xced]

Issues

This pull request fixes issue #578.

Description

Entities with a DateTime property in their key can't be created/read/updated/deleted because OData Web API does not support DateTime in the keys. This pull request addresses this issue by converting DateTimeOffset to DateTime when necessary.

Checklist

• Test cases added
• Build and test with one-click build and test script passed

Additional work necessary

No additional work necessary.

[xuzhg]

@0xced Would you please add several tests to cover your change-sets?

[rayao]

ChangeSetItem and RestierQueryBuilder are at 2 different level, one is in Core and the other publisher, we'd better make the change more consistent.

[0xced]

Would you please add several tests to cover your change-sets?

@xuzhg As I explained, this problem only exists when a DateTime is part of the primary key and I could not find a part of the sample databases used in the tests with a DateTime as part of the primary key. If there’s one I could probably write a test but I don't feel like creating a whole new database just for this. :-/

we'd better make the change more consistent

@rayao What would you suggest to make the change more consistent? I thought that extracting the logic in a helper class was precisely making it consistent.

[0xced]

Ping.

[rayao]

I'm ok with this change.

[robertmclaws]

@0xced I'd like to be able to accept this PR, but you're going to need to catch up on your branch before I can pull it in. Thanks!

[0xced]

I just rebased on master. It seems the continuous integration has failed but unfortunately I'm not authorized to see what has failed.

[robertmclaws]

Don't worry about the CI, I broke the project by moving it to an entirely new structure, so it's going to keep failing until Microsoft gives me access to fix things. I just wanted to make sure the code was current and still necessary so I could pull it in. Approving now, and I hope to have a CI build you can you before the end of the weekend. Thanks for your contribution!