Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$select = complexProperty/complexColProperty query option is not support #196

Closed
VikingsFan opened this issue Jan 21, 2015 · 14 comments
Closed

$select = complexProperty/complexColProperty query option is not support #196

VikingsFan opened this issue Jan 21, 2015 · 14 comments
Assignees
@xuzhg
Labels
feature investigating P1
Milestone
7.3

Comments

@VikingsFan
Copy link
Contributor

query like ?$select=Address/Line1,Address/Line2,Address/PostCode is not support
In System.Web.OData.Formatter.Serialization.SelectExpandNode
ValidatePathIsSupported function :
when segmentCount == 2, only support first segment is a Type Segment, only support paths of type 'cast/structuralOrNavPropertyOrAction'
@VikingsFan VikingsFan self-assigned this Jan 21, 2015
@VikingsFan VikingsFan mentioned this issue Jan 21, 2015
Closed
@VikingsFan VikingsFan added feature and removed bug labels Dec 11, 2015
@VikingsFan VikingsFan mentioned this issue Mar 16, 2016
Closed
@robertmclaws
Copy link
Collaborator

Is there an ETA for supporting this yet? Going on two and a half years now, and it's still needed. Maybe @robward-ms can re-assign it to someone else?

Thanks!

@robertmclaws robertmclaws mentioned this issue May 7, 2017
Closed
@brjohnstmsft brjohnstmsft mentioned this issue Jul 22, 2017
Closed
@robward-ms robward-ms added P2 and removed P3 labels Jul 24, 2017
@brjohnstmsft brjohnstmsft mentioned this issue Jul 26, 2017
Closed
@bdebaere
Copy link
Contributor

bdebaere commented May 2, 2018

@robward-ms Any news on this feature?

@robward-ms
Copy link
Contributor

No news here; the team is focused on getting WebApi AspNetCore finished up before tackling new features.

@brjohnstmsft
Copy link
Contributor

This issue affects Azure Search as well. We are expanding the semantics of $select in our API to handle complex types.

I investigated this issue to the point where I have a sense of the scope of the fix, and it's not small. I already have a workaround in place, so unfortunately it's not worth the effort for my team to take this on. However, I did write an E2E test that will be useful for the next person who tackles this. That was surprisingly difficult too due to some EF dependencies in the E2E tests. I'll send a PR for that shortly.

brjohnstmsft added a commit to brjohnstmsft/WebApi that referenced this issue May 31, 2018
@brjohnstmsft
Adding E2E test coverage for $select support of complex properties
a137809 
In the spirit of TDD, I wrote a failing test before attempting to fix this
issue: OData#196

Unfortunately, the fix looks more like a large and complex feature than just
a simple bug fix, and I don't have bandwidth to take it on right now.
However, the test may still be useful for the next person to make the
attempt.
@brjohnstmsft brjohnstmsft mentioned this issue May 31, 2018
Merged
2 tasks
xuzhg pushed a commit that referenced this issue Jun 2, 2018
@brjohnstmsft @xuzhg
Adding E2E test coverage for $select support of complex properties
bdeba54 
In the spirit of TDD, I wrote a failing test before attempting to fix this
issue: #196

Unfortunately, the fix looks more like a large and complex feature than just
a simple bug fix, and I don't have bandwidth to take it on right now.
However, the test may still be useful for the next person to make the
attempt.
@vsopko
Copy link

vsopko commented Feb 14, 2019

@robward-ms, @xuzhg is there any news on this feature?

@raheph raheph added this to the vNext milestone Jun 12, 2019
@mikepizzo mikepizzo modified the milestones: vNext, 7.2 Jul 19, 2019
@NimaAra
Copy link

NimaAra commented Sep 16, 2019

@mikepizzo @xuzhg Any idea on when we can expect to get this feature?

@mikepizzo mikepizzo added P1 and removed P2 labels Sep 17, 2019
@mikepizzo mikepizzo modified the milestones: 7.2, 7.3 Sep 17, 2019
@suadev
Copy link

suadev commented Oct 16, 2019

@robward-ms, @xuzhg is there any news on this feature?

@xuzhg
Copy link
Member

xuzhg commented Oct 16, 2019

@suadev Thanks for querying. I am busy on this feature now. I hope I can finish it quickly and release it in the next version.

@VenuMadhavPerumalla
Copy link

VenuMadhavPerumalla commented Oct 22, 2019 •
edited
Loading

@xuzhg - We're extending our Api to support Complex Properties and getting the same error during serialization. Kindly let me know if the fix that you're implementing is part of System.Web.OData v5.x and when can we expect the fix to be released

Version of System.Web.Odata being used - 5.9.0

@xuzhg
Copy link
Member

xuzhg commented Oct 22, 2019

@VenuMadhavPerumalla Thanks for letting us know your scenarios. Unfortunately, We are focus on 7.x version and 5.x is in maintenance status.

@keatkeat87
Copy link

It block me to use ef core owned type, any workaround for this ?
@xuzhg nice to hear that you are start doing this feature. Can give a estimate time when the next version release ?
is it possible end of this year ?

@xuzhg xuzhg mentioned this issue Oct 28, 2019
Merged
2 tasks
@xuzhg
Copy link
Member

xuzhg commented Oct 28, 2019

@keatkeat87 Thanks for querying this. I just created a PR to enable it. Hope i can finish it as soon as possible if the code review works well.
BTW, for any one who is interested in this feature are welcome to leave any comments to the PR at #1941.

@suadev
Copy link

suadev commented Nov 28, 2019 •
edited
Loading

@xuzhg any news for your PR?

xuzhg added a commit that referenced this issue Dec 11, 2019
@xuzhg
Enable skip test case because the issue #196 is fixed
a533f8f
@xuzhg
Copy link
Member

xuzhg commented Dec 11, 2019 •
edited
Loading

My PR got merged. It's released in 7.2.3

@xuzhg xuzhg closed this as completed Dec 11, 2019
odero pushed a commit to odero/WebApi that referenced this issue Dec 17, 2019
@xuzhg @odero
Enable skip test case because the issue OData#196 is fixed
c42df0e
@keatkeat87 keatkeat87 mentioned this issue Jan 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuzhg xuzhg

Labels
feature investigating P1
Projects
None yet
Milestone
7.3
Development

No branches or pull requests