Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the null check, fix issue #1755 #2142

Merged
merged 2 commits into from Sep 15, 2020
Merged

Remove the null check, fix issue #1755 #2142

merged 2 commits into from Sep 15, 2020

Conversation

xuzhg
Copy link
Member

@xuzhg xuzhg commented Apr 29, 2020

Issues

This pull request fixes issue https://github.com/OData/odata.net/issues/1755.

#2281

Description

  • SelectExpandBinder generates the "Null" expression can't work for "EntityFramework6".
IsNull = .If ($$it == null) {
            null
        } .Else {
            $$it.Description
        } == null

However, it seems we don't need the "IsNull" check for the complex. So, let's remove this.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

@mikepizzo mikepizzo added this to the 7.5 milestone May 6, 2020
@mikepizzo mikepizzo self-requested a review September 8, 2020 22:59
Copy link
Member

@mikepizzo mikepizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this was added originally? Is this needed for proper null propagation for other data sources?

Can you re-run the tests to verify no breaking changes? It looks like there was a problem executing the CI.

:shipit:

@xuzhg xuzhg removed this from the 7.5 milestone Sep 14, 2020
@mikepizzo mikepizzo added this to the 7.5 milestone Sep 14, 2020
@xuzhg xuzhg merged commit b4066f3 into master Sep 15, 2020
@xuzhg
Copy link
Member Author

xuzhg commented Sep 15, 2020

I checked with "Smit Patel", and the changes here looks good to him. So, I'd merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants