Fix/2265 child collection nextlink #2279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenitoInc
added
the
Ready for review
xuzhg
requested changes
Sep 11, 2020
test/UnitTest/Microsoft.AspNet.OData.Test.Shared/Query/DefaultSkipTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
test/UnitTest/Microsoft.AspNet.OData.Test.Shared/Query/DefaultSkipTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
| [Theory] | ||
| [InlineData("http://localhost/Customers(1)/Orders", 10, null, false, "http://localhost/Customers(1)/Orders?$skip=10")] | ||
| [InlineData("http://localhost/Customers?$expand=Orders", 10, null, false, "http://localhost/Customers?$expand=Orders&$skip=10")] | ||
| public void GetNextPageLink_ReturnsCorrectNextLink(string baseUri, int pageSize, Object instance, bool enableSkipToken, string expectedUri) |
There was a problem hiding this comment.
If the pageSize, instance, enableSkipToken are not changeable, we can move them directly into the test
| private ODataSerializerContext GetContext(bool enableSkipToken = false) | ||
| { | ||
| CustomersModelWithInheritance model = new CustomersModelWithInheritance(); | ||
| IEdmEntitySet entitySet = model.Model.EntityContainer.FindEntitySet("Customers"); |
There was a problem hiding this comment.
I knew there's properties to access the element in the model? maybe you can directly use the properties?
KenitoInc
force-pushed
the
fix/2265-child-collection-nextlink
branch
from
282a71e
to
a6990a4
Compare
|
Merged at 0561a39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #2265 .
Description
Briefly describe the changes of this pull request.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.