Skip to content

Commit

Permalink
Add review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
gathogojr committed Jun 18, 2020
1 parent 1cb241f commit d14b757
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ internal class FakeBindMethods
public static readonly SingleValueNode FakeSingleIntPrimitive =
new ConstantNode(100);

public static readonly SingleValueNode FakeSingleSinglePrimitive =
public static readonly SingleValueNode FakeSingleFloatPrimitive =
new ConstantNode(100.50f);

public static readonly SingleValueNode FakeSingleOpenProperty =
Expand Down Expand Up @@ -93,9 +93,9 @@ public static SingleValueNode BindMethodReturningASingleIntPrimitive(QueryToken
return FakeSingleIntPrimitive;
}

public static SingleValueNode BindMethodReturningASingleSinglePrimitive(QueryToken token)
public static SingleValueNode BindMethodReturningASingleFloatPrimitive(QueryToken token)
{
return FakeSingleSinglePrimitive;
return FakeSingleFloatPrimitive;
}

public static SingleValueNode BindMethodReturningASingleOpenProperty(QueryToken token)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void BindApplyWithAverageInAggregateShouldReturnApplyClause()
{
IEnumerable<QueryToken> tokens = _parser.ParseApply("aggregate(UnitPrice with average as AveragePrice)");

ApplyBinder binder = new ApplyBinder(FakeBindMethods.BindMethodReturningASingleSinglePrimitive, _bindingState);
ApplyBinder binder = new ApplyBinder(FakeBindMethods.BindMethodReturningASingleFloatPrimitive, _bindingState);
ApplyClause actual = binder.BindApply(tokens);

Assert.NotNull(actual);
Expand All @@ -75,7 +75,7 @@ public void BindApplyWithAverageInAggregateShouldReturnApplyClause()

AggregateExpression statement = Assert.IsType<AggregateExpression>(Assert.Single(aggregate.AggregateExpressions));
Assert.NotNull(statement.Expression);
Assert.Same(FakeBindMethods.FakeSingleSinglePrimitive, statement.Expression);
Assert.Same(FakeBindMethods.FakeSingleFloatPrimitive, statement.Expression);
Assert.Equal(AggregationMethod.Average, statement.Method);
Assert.Equal("AveragePrice", statement.Alias);
}
Expand Down

0 comments on commit d14b757

Please sign in to comment.