New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2693: Does not work for reading value for untyped property with odata.type annotated #2694
Conversation
…h odata.type annotated
ODataNestedResourceInfo nestedInfo = null; | ||
this.ReadEntryPayload(payload, this.serverEntitySet, this.serverEntityType, reader => | ||
{ | ||
if (reader.State == ODataReaderState.ResourceStart) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would using a switch
statement be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a switch could be better.
But in this test class, can i leave it so I can follow up with the existing test case pattern?
@@ -1748,6 +1750,237 @@ public void ReadNonOpenEntryEdmUntypedPropertyInComplexTest() | |||
} | |||
#endregion | |||
|
|||
#region declared Edm.Untyped property with odata.type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for the async API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test class only contains sync test cases. We'd set up the environment/configuration for async. Can I leave it to next PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the tests perform I/O, what if you added async tests just for the new test cases you have added? The AsyncStream
wrapper for async tests can help ensure we don't have async regressions where async code calls synchronous code.
Co-authored-by: John Gathogo <john.gathogo@microsoft.com>
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Issues
This pull request fixes #2693.
Description
*Enable to use @odata.type annotation for untyped property for untyped property
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.