Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compatible TNSPECs #25

Merged
merged 6 commits into from
Jan 9, 2023
Merged

Conversation

madisongh
Copy link
Member

This implements the equivalent of the COMPATIBLE_SPEC configuration in the stock L4T update tools, but the computation of the compatibility spec is directly coded, rather than implemented in a separate script and stored in a configuration file.

With this change, we can reduce the size of BUP payloads by including fewer variants, and support bootloader updates for new revisions of Jetson modules when those revisions have no impact on boot firmware compatibility.

Verified with:

  • Jetson TX1
  • Jetson Nano
  • Jetson Nano-eMMC
  • Jetson TX2
  • Jetson TX2-NX
  • Jetson Xavier NX
  • Jetson Xavier NX-eMMC
  • Jetson AGX Xavier

* Compatibility logic derived from the nv-l4t-bootloader-config
  script in stock L4T

* BUP entries are compared to the exact TNSPEC first, then
  the compatibility spec in bup_enumerate_entries()

* Adds some cleanup in TNSPEC parsing handle machine names
  containing hyphens, and the actual maximum number of fields

Signed-off-by: Matt Madison <matt@madison.systems>
Signed-off-by: Matt Madison <matt@madison.systems>
Signed-off-by: Matt Madison <matt@madison.systems>
Signed-off-by: Matt Madison <matt@madison.systems>
Signed-off-by: Matt Madison <matt@madison.systems>
Signed-off-by: Matt Madison <matt@madison.systems>
Copy link
Member

@ichergui ichergui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM 😄

tegra-bootloader-update.c Show resolved Hide resolved
@madisongh
Copy link
Member Author

Note that to actually use these changes, you need BUP payloads that have been created under the same compatibility rules. I'll be submitting the needed TEGRA_BUPGEN_SPECS changes in the meta-tegra PR where I include the upgrade to this version of the tool.

@madisongh madisongh merged commit 86d9f18 into master Jan 9, 2023
@madisongh madisongh deleted the compatible-spec-support branch January 9, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants