don't try to inject nonce attributes into RedirectResponse content #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great plugin, thank you very much for that!
When trying it out, I noticed that the redirect from Rainlabs translate plugin, in connection with the forceURLScheme setting, was visible on the page for a short time. I guess this is because the redirect is built during runtime and comes as a response to a page render.
Since RedirectResponses don't have anything to decorate anyway, it should be safe to just skip the nonce injection for this kind of content/response.
I am not 100% sure if it is a perfect solution, but it solves this problem.
There might be other kinds of content in the "dataHolder", but since the "normal" content is a string , I'm not sure if a reversed check (whitelisting content that should have nonce injected instead of blacklisting content like the RedirectResponse) is possible.