Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip to install Python scripts in platforms #2924

Merged
merged 2 commits into from Apr 20, 2023

Conversation

michael-adler
Copy link
Member

Switching to setuptools required restructuring the platforms tree. Functionality remains the same, including new stubs where the scripts used to be to retain the ability to run the scripts from inside the OPAE SDK source tree.

The platforms database is now stored inside the platmgr Python package instead of in share since Python strongly encourages storing all package data inside the packages tree.

The deprecated CMake installer script that platforms used to run is removed.

@michael-adler michael-adler self-assigned this Apr 19, 2023
@coveralls
Copy link

coveralls commented Apr 19, 2023

Pull Request Test Coverage Report for Build 4758160490

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 65.537%

Files with Coverage Reduction New Missed Lines %
libraries/plugins/xfpga/mmio.c 2 84.72%
Totals Coverage Status
Change from base Build 4757812033: 0.02%
Covered Lines: 13173
Relevant Lines: 20100

💛 - Coveralls

@michael-adler michael-adler marked this pull request as ready for review April 20, 2023 19:13
@michael-adler michael-adler requested review from a team as code owners April 20, 2023 19:14
michael-adler and others added 2 commits April 20, 2023 15:31
Switching to setuptools required restructuring the platforms tree. Functionality
remains the same, including new stubs where the scripts used to be to retain the
ability to run the scripts from inside the OPAE SDK source tree.

The platforms database is now stored inside the platmgr Python package instead
of in share since Python strongly encourages storing all package data inside the
packages tree.

The deprecated CMake installer script that platforms used to run is removed.
Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
@michael-adler michael-adler merged commit b73dc44 into OFS:master Apr 20, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants