Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set FPGA buffer read only for bias mode device bias. #3057

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

anandaravuri
Copy link
Contributor

  • Set Host and FPGA buffer map Writable for Host BIAS mode targeting Host address and Host BIAS mode targeting HDM (Device) address
  • Set FPGA buffer map read-only for device BIAS mode targeting HDM (Device) address

CXL Driver IOCTL buffer map by default Read-only flag value is 0,
Set buffer map flag to DFL_CXL_BUFFER_MAP for Read/write buffers

struct dfl_cxl_cache_buffer_map {
__u32 argsz;
#define DFL_CXL_BUFFER_MAP_WRITABLE 1
__u32 flags;
__u64 user_addr;
__u64 length;
}

PR Title should start with one of the following tags: [Fix]/[Feature]/[Style]/[Update]

[Fix]- Bug Fix

[Feature]- for new feature

[Style]- Grammar or branding fix

[Update]-For an update to an existing feature

------------- Keep everything below this line -------------------------

Description

Describe the issue, update, change or fix and why

Collateral (docs, reports, design examples, case IDs):

  • Document Update Required? (Specify FIM/AFU/Scripts)

Tests added:

Tests run:

  - Set Host and FPGA buffer map  Writable for Host BIAS mode targeting Host address and Host BIAS mode targeting HDM  (Device) address
  - Set FPGA buffer map read-only for device BIAS mode targeting HDM (Device) address

   CXL Driver IOCTL  buffer map by default Read-only flag value is 0,
   Set buffer map flag to  DFL_CXL_BUFFER_MAP for Read/write buffers

   struct dfl_cxl_cache_buffer_map {
 	__u32 argsz;
   #define DFL_CXL_BUFFER_MAP_WRITABLE 1
 	__u32 flags;
 	__u64 user_addr;
 	__u64 length;
   }

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
@anandaravuri anandaravuri requested review from a team as code owners December 7, 2023 23:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7135138533

  • 0 of 12 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 66.494%

Changes Missing Coverage Covered Lines Changed/Added Lines %
samples/cxl_host_exerciser/cxl_he_cmd.h 0 1 0.0%
samples/cxl_host_exerciser/he_cache_test.h 0 11 0.0%
Totals Coverage Status
Change from base Build 7131768027: -0.03%
Covered Lines: 15755
Relevant Lines: 23694

💛 - Coveralls

Copy link
Contributor

@tswhison tswhison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anandaravuri anandaravuri merged commit fefb230 into master Dec 8, 2023
27 checks passed
@anandaravuri anandaravuri deleted the aravuri/fix_fpga_bias_readonly branch December 8, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants