Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:set continuous mode bit for write hit/miss cases tests #3062

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix:set continuous mode bit for write hit/miss cases tests #3062

merged 2 commits into from
Dec 18, 2023

Conversation

anandaravuri
Copy link
Contributor

@anandaravuri anandaravuri commented Dec 15, 2023 •
edited
Loading

CXL HE write hit/miss cases, sets continuous mode bit in rd_cfg instead of wr_cfg.
set continuous mode bit write hit/miss case tests.

Forced stop control register ResetL bit is low causes timeout failures
set ResetL too high for forced stop

@anandaravuri anandaravuri requested a review from a team as a code owner December 15, 2023 19:13
@tswhison
Copy link
Contributor

Could you provide some description in the commit message indicating why the change is required?

fpgamatt
fpgamatt reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@fpgamatt fpgamatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add to the commit message as to why this needs to be done and why the change involving removing setting he_rw_cfg_.continuous_mode_enable?

@coveralls
Copy link

coveralls commented Dec 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7227997314

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 66.565%
Changes Missing Coverage Covered Lines Changed/Added Lines %
samples/cxl_host_exerciser/cxl_he_cache_cmd.h 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
samples/cxl_host_exerciser/cxl_he_cache_cmd.h 1 0.0%
Totals Coverage Status
Change from base Build 7227971434: -0.003%
Covered Lines: 15756
Relevant Lines: 23670
💛 - Coveralls

@anandaravuri
Copy link
Contributor Author

Can add to the commit message as to why this needs to be done and why the change involving removing setting he_rw_cfg_.continuous_mode_enable?

Ananda: updated commit meassge with comments

@anandaravuri
fix:set continuous mode bit for write hit/miss cases tests
9b86e47 
 CXL HE write hit/miss cases, sets continuous mode bit in rd_cfg instead of wr_cfg.
 set continuous mode bit write hit/miss case tests.

 Forced stop  control register ResetL bit is low causes timeout failures
 set ResetL too high for forced stop

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
@anandaravuri anandaravuri merged commit 6c1c4bd into master Dec 18, 2023
27 checks passed
@anandaravuri anandaravuri deleted the aravuri/fix_contmode branch December 18, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpgamatt fpgamatt fpgamatt left review comments

@pcolberg pcolberg pcolberg approved these changes

@tswhison tswhison Awaiting requested review from tswhison

@pl-ravikanth pl-ravikanth Awaiting requested review from pl-ravikanth

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anandaravuri @tswhison @coveralls @fpgamatt @pcolberg