Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Host reads and write miss tests #3064

Merged
merged 1 commit into from Dec 20, 2023
Merged

fix: remove Host reads and write miss tests #3064

merged 1 commit into from Dec 20, 2023

Conversation

anandaravuri
Copy link
Contributor

  • Host reads and write miss tests are same as FPGA reads and write miss, so remove from CXL host exerciser.
  • Changes Host read cache hit opcode to RD_LINE_I

@anandaravuri
fix: remove Host reads and write miss tests
974fe18 
 - Host reads and write miss tests are same as FPGA reads and write miss,
    so remove from CXL host exerciser.
 - Changes Host read cache hit opcode to RD_LINE_I

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
@anandaravuri anandaravuri requested a review from a team as a code owner December 20, 2023 18:22
pcolberg
pcolberg approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandaravuri! Since the tests are the same, why were they added initially?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7279314078

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 66.936%
Changes Missing Coverage Covered Lines Changed/Added Lines %
samples/cxl_host_exerciser/cxl_he_cache_cmd.h 0 1 0.0%
Totals Coverage Status
Change from base Build 7252306388: 0.4%
Covered Lines: 15756
Relevant Lines: 23539
💛 - Coveralls

@anandaravuri anandaravuri merged commit 53b6de9 into master Dec 20, 2023
27 checks passed
@anandaravuri anandaravuri deleted the aravuri/remove_hostrdwrmiss branch December 20, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcolberg pcolberg pcolberg approved these changes

@pl-ravikanth pl-ravikanth Awaiting requested review from pl-ravikanth

@KrishnaSimmadhari KrishnaSimmadhari Awaiting requested review from KrishnaSimmadhari

@fpgamatt fpgamatt Awaiting requested review from fpgamatt

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anandaravuri @coveralls @pcolberg